Add official BannedApiAnalyzers and ban some string parsing methods

Author: YoshiRulz

.global.editorconfig.ini

@@ -376,6 +376,11 @@ dotnet_diagnostic.MEN015.severity = silent
 # Use object-oriented methods instead of top-level statements
 dotnet_diagnostic.MEN016.severity = silent
 
+## Microsoft.CodeAnalysis.BannedApiAnalyzers rules
+
+# Do not use banned APIs
+dotnet_diagnostic.RS0030.severity = error
+
 ## StyleCop spacing rules
 
 # Keywords should be spaced correctly

Directory.Packages.props

@@ -9,6 +9,7 @@
 		<PackageVersion Include="Menees.Analyzers" Version="3.2.2" />
 		<PackageVersion Include="Meziantou.Analyzer" Version="2.0.159" />
 		<PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
+		<PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4" />
 		<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
 		<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0" />
 		<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.1.2" />

src/BannedSymbols.BannedApiAnalyzers.txt

@@ -0,0 +1,11 @@
+M:System.Convert.ToByte(System.String);use byte.{Try,}Parse
+M:System.Convert.ToDecimal(System.String);use decimal.{Try,}Parse
+M:System.Convert.ToDouble(System.String);use double.{Try,}Parse
+M:System.Convert.ToInt16(System.String);use short.{Try,}Parse
+M:System.Convert.ToInt32(System.String);use int.{Try,}Parse
+M:System.Convert.ToInt64(System.String);use long.{Try,}Parse
+M:System.Convert.ToSByte(System.String);use sbyte.{Try,}Parse
+M:System.Convert.ToSingle(System.String);use float.{Try,}Parse
+M:System.Convert.ToUInt16(System.String);use ushort.{Try,}Parse
+M:System.Convert.ToUInt32(System.String);use uint.{Try,}Parse
+M:System.Convert.ToUInt64(System.String);use ulong.{Try,}Parse

src/BizHawk.Client.Common/movie/BasicMovieInfo.cs

@@ -48,8 +48,8 @@ public TimeSpan TimeLength
 
 				if (Header.TryGetValue(HeaderKeys.CycleCount, out var numCyclesStr) && Header.TryGetValue(HeaderKeys.ClockRate, out var clockRateStr))
 				{
-					var numCycles = Convert.ToUInt64(numCyclesStr);
-					var clockRate = Convert.ToDouble(clockRateStr, CultureInfo.InvariantCulture);
+					var numCycles = ulong.Parse(numCyclesStr);
+					var clockRate = double.Parse(clockRateStr, CultureInfo.InvariantCulture);
 					numSeconds = numCycles / clockRate;
 				}
 				else
@@ -68,8 +68,10 @@ public double FrameRate
 			{
 				if (SystemID == VSystemID.Raw.Arcade && Header.TryGetValue(HeaderKeys.VsyncAttoseconds, out var vsyncAttoStr))
 				{
-					const decimal attosInSec = 1000000000000000000;
-					return (double)(attosInSec / Convert.ToUInt64(vsyncAttoStr));
+					const decimal attosInSec = 1_000_000_000_000_000_000.0M;
+					var m = attosInSec;
+					m /= ulong.Parse(vsyncAttoStr);
+					return checked((double) m);
 				}
 				else
 				{

src/BizHawk.Client.EmuHawk/movie/PlayMovie.cs

@@ -422,7 +422,7 @@ private void MovieView_SelectedIndexChanged(object sender, EventArgs e)
 						}
 						break;
 					case HeaderKeys.VsyncAttoseconds:
-						if (_emulator is MAME mame && mame.VsyncAttoseconds != Convert.ToInt64(v))
+						if (_emulator is MAME mame && mame.VsyncAttoseconds != long.Parse(v))
 						{
 							item.BackColor = Color.Pink;
 							item.ToolTipText = $"Expected: {v}\n Actual: {mame.VsyncAttoseconds}";

src/BizHawk.Client.EmuHawk/tools/TAStudio/PatternsForm.cs

@@ -110,7 +110,7 @@ private void ValueNum_ValueChanged(object sender, EventArgs e)
 				return;
 			}
 
-			_values[PatternList.SelectedIndex] = ValueNum.Value.ToString(NumberFormatInfo.InvariantInfo);
+			_values[PatternList.SelectedIndex] = unchecked((int) ValueNum.Value).ToString(NumberFormatInfo.InvariantInfo);
 			UpdatePattern();
 			UpdateDisplay();
 		}
@@ -217,7 +217,7 @@ private void UpdateDisplay()
 					}
 
 					LagBox.Checked = _tastudio.AxisPatterns[index].SkipsLag;
-					ValueNum.Value = Convert.ToDecimal(_values[PatternList.SelectedIndex]);
+					ValueNum.Value = int.Parse(_values[PatternList.SelectedIndex]);
 					CountNum.Value = _counts[PatternList.SelectedIndex];
 				}
 			}
@@ -267,7 +267,7 @@ private void UpdatePattern()
 				{
 					for (int c = 0; c < _counts[i]; c++)
 					{
-						p.Add((int) Convert.ToSingle(_values[i]));
+						p.Add(int.Parse(_values[i]));
 					}
 				}
 

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs

@@ -1323,14 +1323,7 @@ public void EditAnalogProgrammatically(KeyEventArgs e)
 				}
 
 				_axisTypedValue = _axisTypedValue.Substring(startIndex: 0, length: _axisTypedValue.Length - 1); // drop last char
-				if (_axisTypedValue == "" || _axisTypedValue == "-")
-				{
-					value = 0f;
-				}
-				else
-				{
-					value = Convert.ToSingle(_axisTypedValue);
-				}
+				if (!float.TryParse(_axisTypedValue, out value)) value = 0.0f;
 			}
 			else if (e.KeyCode == Keys.Enter)
 			{

src/BizHawk.Emulation.Cores/CPUs/FairchildF8/F3850.Registers.cs

@@ -241,6 +241,8 @@ public ushort RegIRQV
 			}
 		}
 
+		private const string PFX_SCRATCHPAD_REG = "SPR";
+
 		public IDictionary<string, RegisterValue> GetCpuFlagsAndRegisters()
 		{
 			var res = new Dictionary<string, RegisterValue>
@@ -266,17 +268,17 @@ public IDictionary<string, RegisterValue> GetCpuFlagsAndRegisters()
 
 			for (int i = 0; i < 64; i++)
 			{
-				res.Add("SPR" + i, Regs[i]);
+				res.Add(PFX_SCRATCHPAD_REG + i, Regs[i]);
 			}
 
 			return res;
 		}
 
 		public void SetCpuRegister(string register, int value)
 		{
-			if (register.StartsWithOrdinal("SPR"))
+			if (register.StartsWithOrdinal(PFX_SCRATCHPAD_REG))
 			{
-				var reg = Convert.ToInt32(register.Replace("SPR", ""));
+				var reg = int.Parse(register.Substring(startIndex: PFX_SCRATCHPAD_REG.Length));
 
 				if (reg > 63)
 				{

src/MainSlnCommon.props

@@ -18,7 +18,9 @@
 		<RunAnalyzersDuringBuild>false</RunAnalyzersDuringBuild>
 	</PropertyGroup>
 	<ItemGroup>
+		<PackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" PrivateAssets="all" />
 		<Analyzer Include="$(MSBuildProjectDirectory)/../../References/BizHawk.SrcGen.ReflectionCache.dll" />
+		<AdditionalFiles Include="$(MSBuildThisFileDirectory)/BannedSymbols.BannedApiAnalyzers.txt" />
 		<Using Include="System" />
 	</ItemGroup>
 	<ItemGroup Condition=" '$(Configuration)' != 'Debug' ">