Treewide: Rework input handling, frame limiter and serviceRepaints

The idea behind this is fixing a bunch of regressions caused by the
newer input handling, and the better render sync code.

Frame limiting is now donw by lcdui's Canvas and GameCanvas instead
of MobilePlatform's over-arching flushGraphics() method, which was
prone to inaccuracies if games heavily used serviceRepaints() to
constantly sync the render state. Most notably, this rework fixes
Sonic 1's regression of improper frame-pacing due to serviceRepaints
calls (which made the framecounter and limiter think the game was
running at double the framerate), at the same time it keeps the
Panasonic VS3 version working because it only needs serviceRepaints
to sync the upper area of the screen. Previously fixing one by
messing with serviceRepaints() logic would break the other. Beyond
Sonic 1, it should fix pretty much any instance of inaccurate timing
in other games without reintroducing flickering in games such as
Pipyakas/Boombakas, so it's related to issues #10 and #68.

Furthermore, input is no longer queued into serial calls, because
it's no longer needed. This helps Puzzlegeddon (#71), and Ratatouille
without breaking anything else that i could find at the moment, and
Ratatouille was one that previously required queuing those inputs.

Heroes Lore: Wind of Soltia regressed randomly at some point and
gets stuck in a white screen after pressing any key, so it can't
really be tested further, although the input delay when pressing
keys appears to be gone from it as well.

Author: AShiningRay

src/javax/microedition/lcdui/Canvas.java

@@ -166,13 +166,15 @@ public void pointerReleased(int x, int y) { }
 
 	public void repaint(int x, int y, int width, int height)
 	{
+		Mobile.getPlatform().limitFps();
 		try 
 		{
 			if (!isShown() || listCommands) { return; }
 
 			// TODO: This might be an issue
 			if (isPainting) 
 			{
+				Mobile.log(Mobile.LOG_WARNING, Canvas.class.getPackage().getName() + "." + Canvas.class.getSimpleName() + ": " +"Recursive repaint attempted");
 				// we need this to avoid stackoverflow
 				// but it seems the underlying problem is that when paint calls
 				// repaint, we shouldn't even land here...
@@ -208,10 +210,11 @@ public void repaint(int x, int y, int width, int height)
 	public void serviceRepaints() 
 	{
 		// TODO: Flesh this out properly, some games might need it.
-		if(!isShown() || isPainting) { return; }
+		if(!isShown()) { return; }
 
-		// Right now all this does is force a redraw, no queue consideration is made.
+		// serviceRepaints has to force any pending repaints to be serviced
 		Mobile.getPlatform().flushGraphics(platformImage, 0, 0, width, height);
+		isPainting = false;
 	}
 
 	public void setFullScreenMode(boolean mode)

src/javax/microedition/lcdui/Display.java

@@ -46,7 +46,6 @@ public class Display
 
 	private final Queue<Runnable> serialCalls;
 	private final Thread serialThread;
-	private volatile boolean processingCalls;
 
 	private boolean isSettingCurrent = false;
 
@@ -59,7 +58,6 @@ public Display()
 		Mobile.setDisplay(this);
 
 		serialCalls = new LinkedList<>();
-		processingCalls = true;
 		serialThread = new Thread(this::processSerialCalls);
 		serialThread.start();
 	}
@@ -71,27 +69,15 @@ public void callSerially(Runnable r)
 
 	private void processSerialCalls() 
 	{
-		while (processingCalls) 
+		while (true) 
 		{
-			Runnable runnable = null;
-
 			synchronized (serialCalls) 
 			{
-				if (!serialCalls.isEmpty()) { runnable = serialCalls.poll(); }
-				
-				if (runnable != null) { runnable.run(); } 
+				if (!serialCalls.isEmpty()) { serialCalls.poll().run(); }
 			}
 		}
 	}
 
-	public void stop() // Didn't find an use for this yet
-	{
-		processingCalls = false;
-		serialThread.interrupt();
-		try { serialThread.join(); } 
-		catch (InterruptedException e) { Thread.currentThread().interrupt(); }
-	}
-
 	public boolean flashBacklight(int duration) 
 	{
 		try 

src/javax/microedition/lcdui/game/GameCanvas.java

@@ -52,6 +52,10 @@ public void paint(Graphics g) { }
 
 	public void flushGraphics(int x, int y, int width, int height)
 	{
+		Mobile.getPlatform().limitFps();
+
+		if (width <= 0 || height <= 0 || x + width < 0 || y + height < 0 || x >= this.width || y >= this.height) { return; }
+
 		Mobile.getPlatform().flushGraphics(platformImage, x, y, width, height);
 	}
 

src/org/recompile/mobile/MobilePlatform.java

@@ -151,34 +151,34 @@ public void resizeLCD(int width, int height)
 
 	public void keyPressed(int keycode)
 	{
-		Mobile.getDisplay().callSerially(() -> { updateKeyState(Mobile.getGameAction(keycode), 1); });
-		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { Mobile.getDisplay().callSerially(() -> {displayable.keyPressed(keycode); }); }
+		updateKeyState(Mobile.getGameAction(keycode), 1);
+		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { displayable.keyPressed(keycode); }
 	}
 
 	public void keyReleased(int keycode)
 	{
-		Mobile.getDisplay().callSerially(() -> {updateKeyState(Mobile.getGameAction(keycode), 0); });
-		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { Mobile.getDisplay().callSerially(() -> {displayable.keyReleased(keycode); }); }
+		updateKeyState(Mobile.getGameAction(keycode), 0);
+		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { displayable.keyReleased(keycode); }
 	}
 
 	public void keyRepeated(int keycode)
 	{
-		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { Mobile.getDisplay().callSerially(() -> {displayable.keyRepeated(keycode); }); }
+		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { displayable.keyRepeated(keycode); }
 	}
 
 	public void pointerDragged(int x, int y)
 	{
-		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { Mobile.getDisplay().callSerially(() -> {displayable.pointerDragged(x, y); }); }
+		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { displayable.pointerDragged(x, y); }
 	}
 
 	public void pointerPressed(int x, int y)
 	{
-		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { Mobile.getDisplay().callSerially(() -> {displayable.pointerPressed(x, y); }); }
+		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { displayable.pointerPressed(x, y); }
 	}
 
 	public void pointerReleased(int x, int y)
 	{
-		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { Mobile.getDisplay().callSerially(() -> {displayable.pointerReleased(x, y); }); }
+		if ((displayable = Mobile.getDisplay().getCurrent()) != null) { displayable.pointerReleased(x, y); }
 	}
 
 	private void updateKeyState(int key, int val)
@@ -298,7 +298,6 @@ public final void flushGraphics(Image img, int x, int y, int width, int height)
 
 		if(!showFPS.equals("Off")) { showFPS();}
 		painter.run(); // Update the frontend's painter first to then process inputs
-		limitFps();
 
 		processInputs();
 	}
@@ -342,8 +341,9 @@ else if (pressedKeys[i] == false && previouslyPressed[i] == true)
 		}
 	}
 
-	private void limitFps() 
+	public void limitFps() 
 	{
+		frameCount++;
 		if(Mobile.limitFPS == 0) { lastRenderTime = System.nanoTime(); return; }
 
 		requiredFrametime = 1_000_000_000 / Mobile.limitFPS;
@@ -364,8 +364,6 @@ private void limitFps()
 	// For now, the logic here works by updating the framerate counter every second
 	private final void showFPS() 
 	{
-		frameCount++;
-	
 		if (System.nanoTime() - lastFpsTime >= 1_000_000_000) 
 		{ 
 			fps = frameCount;