Tag Editor Issue #1631
Comments
|
Can't repro - can you toss me the file that caused this over Discord? Is that the full trace? It seems a bit short/possibly missing a followup
Can't fix issues that aren't known, don't feel bad about reporting issues just because you find a lot of them. |
|
I don't have DIscord. The only thing I left from the trace was the file list. "Can't fix issues that aren't known, don't feel bad about reporting issues just because you find a lot of them." Something to note is the my tag editor only does one file at a time. If I go into the conf file and change it to another that will do "the kitchen sink" it works. The caveat is the inconsistent behavior of Tauon where some times it tries to open the whole playlist, some times the artist and some times it will open the selected song...in which case my original tag editor works. However Tauon doesn't behave correctly with the selection or in response to the editor. Here I got this just now i.e. completely reproducible for me. |
|
Ah, you cut off the last line in the OP. What does executing: give you? Perhaps something like just Looks quite long of a command, and maybe it's not enjoying the unicode. |
|
What does (long snippet) give me? A headache ;) It gives me nothing because the paths are hard quoted with env variables. A little find replace magic it just craps out because of a song. However if I just take the song it errors out on and use it it works fine. Again tageditor doesn't do multiple files. Just one at a time. I also noticed some inconsistent syntax in there. Some things are white space separated, other things are comma separated...lots of hard quote soft quote flip flopping... Just curious but why does Tauon use that whacky absolute to relative path syntax? $HOME/Documents/playlists/../../Music/Misc/song.mp3 |
|
Yeah why are those paths like that? How were these tracks imported? If tracks necessarily get imported like that then we really should be unpacking those paths. |
Ah, my find & replace did not account for some of it having double quotes, it flip flops because it defaults to single quotes but some of it has single quotes in the file name. I suppose this is a question of asking https://github.com/Martchus/tageditor to implement better CLI support for multiple files, like other tools have, or adding a workaround for the specific app name in |
|
Na I just set Puddle Tag as my editor from here on out but Tauon needs to "not assume" heh. That said this is kinda less about the pass to the external editor than it is about the inconsistent behavior where some times it sends the whole playlist, some times just the tracks in the playlist of the same artist and some times the track I select to edit...there is either some UI thing that changes this on purpose I'm not seeing (note my user feedback stuff on the pinned playlist bug report, Tauon knows there is an issue with the pass but never notifies the user) or the select system to send to the editor is borked. I've found lots of UI/feedback issues that seem to tie all my bug reports together. As for the whacky hard to relative paths. I imported an m3u playlist from qmmp. |
|
As a quick addendum to my comments about the odd/inconsistent behavior when selecting tracks for tagging I think I figured that out while hunting down a lot of the little things I've found and put in #1633 . This looks like the intended behavior but it wasn't clear at first. When you select to edit tags it doesn't go by what you select but rather what heading it is under. So if the heading for the file is "cool songs" then when you select -one- track to edit the tags of and it's in the heading "cool songs" it pipes all of "cool songs" rather than the track you select. I think part of why this didn't make sense is because I've seen duplicate files have different headings despite being from the same artist, folder, etc. That combined with not seeing "the pattern" that if I have a single song from a specific folder or artist and tried to edit the tags it would work with my original tag editor. However if the file I was trying to tag was in a group/folder or from an artist of which there are other songs from the same artist/folder then things went sideways. This is all tied with the fact that if you say select somewhere in the playlist UI but not explicitly ON a song it still selects the song your click is closest to. So when you right click and go to meta > Edit With XXX it gives the impression you are editing ONE file, the file you selected. It never says "edit group tags" or "edit artist tags." Small things like this are misleading and gave me the wrong impression. |
Uh oh!
There was an error while loading. Please reload this page.
Desktop (please complete the following information):
Describe the bug
I am trying to tag a song. The first one the tag editor opened fine but when I tried to do another I got a vague message about tags will be reloaded after application closes. I checked and my tag editor wasn't running/open. After trying and restarting a few times I decided to try launching from a term to see if anything shook loose...
There is more but it's a ton of file paths. It looks to be trying to open everything in the playlist rather than the selected song.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should open the tag editor rather than throw errors then complain the editor is still open when it never opened it in the first place due to said errors.
Screenshots/Videos
If applicable, add screenshots/videos to help explain your problem.
Tauon log
See above
Additional context
I also notice inconsistent behavior. Some times if I try to tag something it opens everything from the artist. The next time it opens the whole playlist for tagging...and sometimes it does what I expect which was/is to open the selected file for tagging.
I see in the playlist some songs have their artist as the little header above a track where some (despite having things tagged) just shows the folder for the little header. It seems like if you select a song that has the artist over top it will open all for the artist despite selecting a single song. If you select a track to tag that has a folder in the little heading section it opens the whole playlist. Is this intended?
Sorry I feel like I'm flooding you with tons of issues I'm finding all at once but I have another note that is semi off topic.
It appears that remove duplicates is also broken. It seems to work on path comparison in a way that you can have three of the same track and it will fail to see a duplicate if they are added in a way that leaves then with differing paths. So playlist import where you have a relative path for one, another has a absolute and one has some kind of expansion. So
~/Music/home/user/Music$HOME/Music./Musicetc.I did some more fiddling and notice all exported playlists have some whack syntax. They always export from where the playlists are saved. You can't set a standard directory for playlists either which is annoying. So everything in a playlist is saved as /home/user/path/to/playlists/../../Music/artistfolder/song.ext This is really convoluted and then means find duplicate fails if paths are added/appended outside the playlist.
I've actually found a ton of issues every since I started doing more than some basic add/play files. I won't flood with more bugs but there are a lot of ui/logic issues scattered about the application.
The text was updated successfully, but these errors were encountered: