Merge pull request #133 from Atry/hide-bindingBindableSeq

Atry · web-flow · commit 431b9ee59cf8 · 2021-11-06T02:26:50.000-07:00
Hide bindingBindableSeq, which results ambiguous implicit values
diff --git a/shared/src/main/scala/com/thoughtworks/binding/bindable/package.scala b/shared/src/main/scala/com/thoughtworks/binding/bindable/package.scala
@@ -125,7 +125,8 @@ package bindable {
   }
 
   private[bindable] trait LowPriorityBindableSeq1 extends LowPriorityJsBindableSeq2 {
-    implicit def bindingBindableSeq[Value0]: BindableSeq.Aux[Binding[Value0], Value0] =
+    @deprecated("Resulting ambiguous implicit values with watchableBindableSeq", "2.1.1")
+    private[bindable] def bindingBindableSeq[Value0]: BindableSeq.Aux[Binding[Value0], Value0] =
       new BindableSeq[Binding[Value0]] {
         type Value = Value0
         def toBindingSeq(from: Binding[Value0]): BindingSeq[Value] = SingletonBindingSeq(from)

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,8 @@ package bindable {`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`private[bindable] trait LowPriorityBindableSeq1 extends LowPriorityJsBindableSeq2 {`
`128`		`- implicit def bindingBindableSeq[Value0]: BindableSeq.Aux[Binding[Value0], Value0] =`
	`128`	`+ @deprecated("Resulting ambiguous implicit values with watchableBindableSeq", "2.1.1")`
	`129`	`+ private[bindable] def bindingBindableSeq[Value0]: BindableSeq.Aux[Binding[Value0], Value0] =`
`129`	`130`	`new BindableSeq[Binding[Value0]] {`
`130`	`131`	`type Value = Value0`
`131`	`132`	`def toBindingSeq(from: Binding[Value0]): BindingSeq[Value] = SingletonBindingSeq(from)`