-
Notifications
You must be signed in to change notification settings - Fork 13
pandapower collections plotting update #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am on holidays now so I can't check it out right now, all I can say from the screenshot it looks very well! I will get back to you as soon as I am back, end of next week probably |
enjoy, let me work on n local copy of collections and then you can pull whatever i get done later. i also need some time for real work. |
Hey, so I am back and I had a look at the GUI again. I don't have any general comments, everything looks like its going in the right direction, very nice! I worked a little bit more on it and now implemented:
|
HI, thank you. I have been travelling a bit as well and pretty busy at work. what type of networks is .p? is that the network pickle? |
Yes .p is a network saved with pp.to_pickle I refactored the element window to avoid copy&paste code. There is now a base class ElementWindow where most of the interaction is defined. The LineWindow class is a subclass of ElementWindow, where only three functions have to be defined:
For buses it is a bit more complicated because of the geodata, which is why more functions have to be defined. For all other elements it should however work as demonstrated with lines |
I have added a load window as well. Works pretty straightforward with the new ElementWindow class |
I have changed the display in the network model tab from html tbales to QtableWidgets. This has the advantage that you can now doublecklick on the table, and the same window from the collection pops up I also added ext_grid collection, although the grid does not yet work properly (it gets smaller/larger when zooming, should be constant). But it works for now and doublecklicks on it are also detected. Some general comments:
|
I added the ui file main.ui as a suggestion for a new layout. I did not connect anything yet, it is just a layout suggestion. Please take a look at it and tell me what you think. We should also look into the GridCal layout which looks very professional in my opinion: https://github.com/SanPen/GridCal Maybe we can catch some ideas from there. |
sure ,traveling at the moment. but i am not stuck with anything in the layout. I new nothing about qt when strarting so cleaning up is cool! |
hi, i am busy having a look at this. it is looking good. |
HI, I am trying to get to run, just have some work to do. I do not think the imports between Qt4 and 5 is that simple. The two packages have the imports that is slightly different/ that is why i abondoned, but the picture looks good and I will see if i can get it to run |
I am currently working with PyQt4 on another project and I didn't want to skip between versions, so I started to make it work with PyQt4. But I didn't change anython about the PyQT5 imports (I think?), so why is it not working with PyQt5 now? Are there some differences in the Widgets also? |
Hi Tobie, will you have time to continue working on this in the foreseeable future? I feel like the GUI is 80% ready to work with, so it would be a shame to not put in the time to get the last 20% to work. I will also try to invest some more time, I hope I can get around to it next week. |
@lthurner HI, I have spent some time cleaning up the code, did some refactoring, and started playing with the collections. I have changed the dummy network to the tutorial network in the documentation and added some geodata.
I just couln't get pyside to import the ui file for now. Will keep this for later.
I have added the
infofunc
to the collections builder, but I think it's not implemented on the plotting.collections side on thepandapower
project.(bus and lines are and respond to double clicks) I think you just wanted to get the examples out as quickly as possible. What is your proposal on updates here?You can also now load and save excel case files.
The text was updated successfully, but these errors were encountered: