fix: createLiteral removed in 5.1 microsoft/TypeScript#53077 (comment) (#1574)

johnnyreilly · web-flow · commit 5f28651df20e · 2023-03-04T21:00:45.000Z
* fix: createLiteral removed in 5.1 microsoft/TypeScript#53077 (comment) * fix: factory
diff --git a/test/comparison-tests/customTransformer/uppercaseStringLiteralTransformer.js b/test/comparison-tests/customTransformer/uppercaseStringLiteralTransformer.js
@@ -6,7 +6,8 @@ var transformer = function (context) {
         if (node.kind === ts.SyntaxKind.StringLiteral) {
             var text = node.text;
             if (text !== text.toUpperCase()) {
-                return ts.createLiteral(text.toUpperCase());
+                    // createLiteral removed in 5.1 https://github.com/microsoft/TypeScript/issues/53077#issuecomment-1453846217
+                    return ts.createLiteral ? ts.createLiteral(text.toUpperCase()) : ts.factory.createStringLiteral(text.toUpperCase());
             }
         }
         return ts.visitEachChild(node, visitor, context);
diff --git a/test/comparison-tests/customTransformerUsingPathString/uppercaseStringLiteralTransformer.js b/test/comparison-tests/customTransformerUsingPathString/uppercaseStringLiteralTransformer.js
@@ -6,7 +6,8 @@ var transformer = function (context) {
         if (node.kind === ts.SyntaxKind.StringLiteral) {
             var text = node.text;
             if (text !== text.toUpperCase()) {
-                return ts.createLiteral(text.toUpperCase());
+                    // createLiteral removed in 5.1 https://github.com/microsoft/TypeScript/issues/53077#issuecomment-1453846217
+                    return ts.createLiteral ? ts.createLiteral(text.toUpperCase()) : ts.factory.createStringLiteral(text.toUpperCase());
             }
         }
         return ts.visitEachChild(node, visitor, context);
diff --git a/test/execution-tests/loaderOptions/uppercaseStringLiteralTransformer.js b/test/execution-tests/loaderOptions/uppercaseStringLiteralTransformer.js
@@ -7,7 +7,8 @@ var transformer = function (context) {
             var text = node.text;
             if (text.match(/^Hello from submodule/) !== null) {
                 if (text !== text.toUpperCase()) {
-                    return ts.createLiteral(text.toUpperCase());
+                    // https://github.com/microsoft/TypeScript/issues/53077#issuecomment-1453846217
+                    return ts.createLiteral ? ts.createLiteral(text.toUpperCase()) : ts.factory.createStringLiteral(text.toUpperCase());
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,8 @@ var transformer = function (context) {`
`6`	`6`	`if (node.kind === ts.SyntaxKind.StringLiteral) {`
`7`	`7`	`var text = node.text;`
`8`	`8`	`if (text !== text.toUpperCase()) {`
`9`		`- return ts.createLiteral(text.toUpperCase());`
	`9`	`+ // createLiteral removed in 5.1 https://github.com/microsoft/TypeScript/issues/53077#issuecomment-1453846217`
	`10`	`+ return ts.createLiteral ? ts.createLiteral(text.toUpperCase()) : ts.factory.createStringLiteral(text.toUpperCase());`
`10`	`11`	`}`
`11`	`12`	`}`
`12`	`13`	`return ts.visitEachChild(node, visitor, context);`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,8 @@ var transformer = function (context) {`
`7`	`7`	`var text = node.text;`
`8`	`8`	`if (text.match(/^Hello from submodule/) !== null) {`
`9`	`9`	`if (text !== text.toUpperCase()) {`
`10`		`- return ts.createLiteral(text.toUpperCase());`
	`10`	`+ // https://github.com/microsoft/TypeScript/issues/53077#issuecomment-1453846217`
	`11`	`+ return ts.createLiteral ? ts.createLiteral(text.toUpperCase()) : ts.factory.createStringLiteral(text.toUpperCase());`
`11`	`12`	`}`
`12`	`13`	`}`
`13`	`14`	`}`