Skip to content

Commit 444c526

Browse files
authored
update core (#466)
* update periphery * update imports * forge fmt + stable foundry
1 parent d7ca72e commit 444c526

20 files changed

+169
-245
lines changed

lib/v4-core

Submodule v4-core updated 51 files

src/PositionManager.sol

+3-2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import {StateLibrary} from "@uniswap/v4-core/src/libraries/StateLibrary.sol";
1111
import {TransientStateLibrary} from "@uniswap/v4-core/src/libraries/TransientStateLibrary.sol";
1212
import {IAllowanceTransfer} from "permit2/src/interfaces/IAllowanceTransfer.sol";
1313
import {TickMath} from "@uniswap/v4-core/src/libraries/TickMath.sol";
14+
import {ModifyLiquidityParams, SwapParams} from "@uniswap/v4-core/src/types/PoolOperation.sol";
1415

1516
import {IPositionDescriptor} from "./interfaces/IPositionDescriptor.sol";
1617
import {ERC721Permit_v4} from "./base/ERC721Permit_v4.sol";
@@ -423,7 +424,7 @@ contract PositionManager is
423424
if (liquidity > 0) {
424425
BalanceDelta liquidityDelta;
425426
// do not use _modifyLiquidity as we do not need to notify on modification for burns.
426-
IPoolManager.ModifyLiquidityParams memory params = IPoolManager.ModifyLiquidityParams({
427+
ModifyLiquidityParams memory params = ModifyLiquidityParams({
427428
tickLower: info.tickLower(),
428429
tickUpper: info.tickUpper(),
429430
liquidityDelta: -(liquidity.toInt256()),
@@ -496,7 +497,7 @@ contract PositionManager is
496497
) internal returns (BalanceDelta liquidityDelta, BalanceDelta feesAccrued) {
497498
(liquidityDelta, feesAccrued) = poolManager.modifyLiquidity(
498499
poolKey,
499-
IPoolManager.ModifyLiquidityParams({
500+
ModifyLiquidityParams({
500501
tickLower: info.tickLower(),
501502
tickUpper: info.tickUpper(),
502503
liquidityDelta: liquidityChange,

src/V4Router.sol

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {DeltaResolver} from "./base/DeltaResolver.sol";
1616
import {Actions} from "./libraries/Actions.sol";
1717
import {ActionConstants} from "./libraries/ActionConstants.sol";
1818
import {BipsLibrary} from "./libraries/BipsLibrary.sol";
19+
import {SwapParams} from "@uniswap/v4-core/src/types/PoolOperation.sol";
1920

2021
/// @title UniswapV4Router
2122
/// @notice Abstract contract that contains all internal logic needed for routing through Uniswap v4 pools
@@ -160,7 +161,7 @@ abstract contract V4Router is IV4Router, BaseActionsRouter, DeltaResolver {
160161
unchecked {
161162
BalanceDelta delta = poolManager.swap(
162163
poolKey,
163-
IPoolManager.SwapParams(
164+
SwapParams(
164165
zeroForOne, amountSpecified, zeroForOne ? TickMath.MIN_SQRT_PRICE + 1 : TickMath.MAX_SQRT_PRICE - 1
165166
),
166167
hookData

src/base/BaseV4Quoter.sol

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {QuoterRevert} from "../libraries/QuoterRevert.sol";
88
import {SafeCallback} from "../base/SafeCallback.sol";
99
import {PoolId} from "@uniswap/v4-core/src/types/PoolId.sol";
1010
import {TickMath} from "@uniswap/v4-core/src/libraries/TickMath.sol";
11+
import {SwapParams} from "@uniswap/v4-core/src/types/PoolOperation.sol";
1112

1213
abstract contract BaseV4Quoter is SafeCallback {
1314
using QuoterRevert for *;
@@ -41,7 +42,7 @@ abstract contract BaseV4Quoter is SafeCallback {
4142
{
4243
swapDelta = poolManager.swap(
4344
poolKey,
44-
IPoolManager.SwapParams({
45+
SwapParams({
4546
zeroForOne: zeroForOne,
4647
amountSpecified: amountSpecified,
4748
sqrtPriceLimitX96: zeroForOne ? TickMath.MIN_SQRT_PRICE + 1 : TickMath.MAX_SQRT_PRICE - 1

src/base/hooks/BaseTokenWrapperHook.sol

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {Hooks} from "@uniswap/v4-core/src/libraries/Hooks.sol";
1212
import {IPoolManager} from "@uniswap/v4-core/src/interfaces/IPoolManager.sol";
1313
import {BaseHook} from "../../utils/BaseHook.sol";
1414
import {DeltaResolver} from "../DeltaResolver.sol";
15+
import {ModifyLiquidityParams, SwapParams} from "@uniswap/v4-core/src/types/PoolOperation.sol";
1516

1617
/// @title Base Token Wrapper Hook
1718
/// @notice Abstract base contract for implementing token wrapper hooks in Uniswap V4
@@ -96,7 +97,7 @@ abstract contract BaseTokenWrapperHook is BaseHook, DeltaResolver {
9697

9798
/// @notice Prevents liquidity operations on wrapper pools
9899
/// @dev Always reverts as liquidity is managed through the token wrapper
99-
function _beforeAddLiquidity(address, PoolKey calldata, IPoolManager.ModifyLiquidityParams calldata, bytes calldata)
100+
function _beforeAddLiquidity(address, PoolKey calldata, ModifyLiquidityParams calldata, bytes calldata)
100101
internal
101102
pure
102103
override
@@ -111,7 +112,7 @@ abstract contract BaseTokenWrapperHook is BaseHook, DeltaResolver {
111112
/// @return selector The function selector
112113
/// @return swapDelta The input/output token amounts for pool accounting
113114
/// @return lpFeeOverride The fee override (always 0 for wrapper pools)
114-
function _beforeSwap(address, PoolKey calldata, IPoolManager.SwapParams calldata params, bytes calldata)
115+
function _beforeSwap(address, PoolKey calldata, SwapParams calldata params, bytes calldata)
115116
internal
116117
override
117118
returns (bytes4, BeforeSwapDelta swapDelta, uint24)

src/utils/BaseHook.sol

+21-22
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {BalanceDelta} from "@uniswap/v4-core/src/types/BalanceDelta.sol";
88
import {PoolKey} from "@uniswap/v4-core/src/types/PoolKey.sol";
99
import {BeforeSwapDelta} from "@uniswap/v4-core/src/types/BeforeSwapDelta.sol";
1010
import {ImmutableState} from "../base/ImmutableState.sol";
11+
import {ModifyLiquidityParams, SwapParams} from "@uniswap/v4-core/src/types/PoolOperation.sol";
1112

1213
/// @title Base Hook
1314
/// @notice abstract contract for hook implementations
@@ -61,13 +62,13 @@ abstract contract BaseHook is IHooks, ImmutableState {
6162
function beforeAddLiquidity(
6263
address sender,
6364
PoolKey calldata key,
64-
IPoolManager.ModifyLiquidityParams calldata params,
65+
ModifyLiquidityParams calldata params,
6566
bytes calldata hookData
6667
) external onlyPoolManager returns (bytes4) {
6768
return _beforeAddLiquidity(sender, key, params, hookData);
6869
}
6970

70-
function _beforeAddLiquidity(address, PoolKey calldata, IPoolManager.ModifyLiquidityParams calldata, bytes calldata)
71+
function _beforeAddLiquidity(address, PoolKey calldata, ModifyLiquidityParams calldata, bytes calldata)
7172
internal
7273
virtual
7374
returns (bytes4)
@@ -79,26 +80,25 @@ abstract contract BaseHook is IHooks, ImmutableState {
7980
function beforeRemoveLiquidity(
8081
address sender,
8182
PoolKey calldata key,
82-
IPoolManager.ModifyLiquidityParams calldata params,
83+
ModifyLiquidityParams calldata params,
8384
bytes calldata hookData
8485
) external onlyPoolManager returns (bytes4) {
8586
return _beforeRemoveLiquidity(sender, key, params, hookData);
8687
}
8788

88-
function _beforeRemoveLiquidity(
89-
address,
90-
PoolKey calldata,
91-
IPoolManager.ModifyLiquidityParams calldata,
92-
bytes calldata
93-
) internal virtual returns (bytes4) {
89+
function _beforeRemoveLiquidity(address, PoolKey calldata, ModifyLiquidityParams calldata, bytes calldata)
90+
internal
91+
virtual
92+
returns (bytes4)
93+
{
9494
revert HookNotImplemented();
9595
}
9696

9797
/// @inheritdoc IHooks
9898
function afterAddLiquidity(
9999
address sender,
100100
PoolKey calldata key,
101-
IPoolManager.ModifyLiquidityParams calldata params,
101+
ModifyLiquidityParams calldata params,
102102
BalanceDelta delta,
103103
BalanceDelta feesAccrued,
104104
bytes calldata hookData
@@ -109,7 +109,7 @@ abstract contract BaseHook is IHooks, ImmutableState {
109109
function _afterAddLiquidity(
110110
address,
111111
PoolKey calldata,
112-
IPoolManager.ModifyLiquidityParams calldata,
112+
ModifyLiquidityParams calldata,
113113
BalanceDelta,
114114
BalanceDelta,
115115
bytes calldata
@@ -121,7 +121,7 @@ abstract contract BaseHook is IHooks, ImmutableState {
121121
function afterRemoveLiquidity(
122122
address sender,
123123
PoolKey calldata key,
124-
IPoolManager.ModifyLiquidityParams calldata params,
124+
ModifyLiquidityParams calldata params,
125125
BalanceDelta delta,
126126
BalanceDelta feesAccrued,
127127
bytes calldata hookData
@@ -132,7 +132,7 @@ abstract contract BaseHook is IHooks, ImmutableState {
132132
function _afterRemoveLiquidity(
133133
address,
134134
PoolKey calldata,
135-
IPoolManager.ModifyLiquidityParams calldata,
135+
ModifyLiquidityParams calldata,
136136
BalanceDelta,
137137
BalanceDelta,
138138
bytes calldata
@@ -141,16 +141,15 @@ abstract contract BaseHook is IHooks, ImmutableState {
141141
}
142142

143143
/// @inheritdoc IHooks
144-
function beforeSwap(
145-
address sender,
146-
PoolKey calldata key,
147-
IPoolManager.SwapParams calldata params,
148-
bytes calldata hookData
149-
) external onlyPoolManager returns (bytes4, BeforeSwapDelta, uint24) {
144+
function beforeSwap(address sender, PoolKey calldata key, SwapParams calldata params, bytes calldata hookData)
145+
external
146+
onlyPoolManager
147+
returns (bytes4, BeforeSwapDelta, uint24)
148+
{
150149
return _beforeSwap(sender, key, params, hookData);
151150
}
152151

153-
function _beforeSwap(address, PoolKey calldata, IPoolManager.SwapParams calldata, bytes calldata)
152+
function _beforeSwap(address, PoolKey calldata, SwapParams calldata, bytes calldata)
154153
internal
155154
virtual
156155
returns (bytes4, BeforeSwapDelta, uint24)
@@ -162,14 +161,14 @@ abstract contract BaseHook is IHooks, ImmutableState {
162161
function afterSwap(
163162
address sender,
164163
PoolKey calldata key,
165-
IPoolManager.SwapParams calldata params,
164+
SwapParams calldata params,
166165
BalanceDelta delta,
167166
bytes calldata hookData
168167
) external onlyPoolManager returns (bytes4, int128) {
169168
return _afterSwap(sender, key, params, delta, hookData);
170169
}
171170

172-
function _afterSwap(address, PoolKey calldata, IPoolManager.SwapParams calldata, BalanceDelta, bytes calldata)
171+
function _afterSwap(address, PoolKey calldata, SwapParams calldata, BalanceDelta, bytes calldata)
173172
internal
174173
virtual
175174
returns (bytes4, int128)

0 commit comments

Comments
 (0)