fix: Pattern data view rendering of bitfields within bitfields being broken

WerWolv · WerWolv · commit a5eb031401d4 · 2024-05-07T23:32:51.000+02:00
diff --git a/plugins/ui/source/ui/pattern_drawer.cpp b/plugins/ui/source/ui/pattern_drawer.cpp
@@ -135,11 +135,12 @@ namespace hex::ui {
         }
 
         void drawSizeColumn(const pl::ptrn::Pattern& pattern) {
-            ImGui::TableNextColumn();
             if (auto *bitfieldMember = dynamic_cast<const pl::ptrn::PatternBitfieldMember*>(&pattern); bitfieldMember != nullptr && bitfieldMember->getParentBitfield() != nullptr)
                 drawSizeColumnForBitfieldMember(*bitfieldMember);
-            else
+            else {
+                ImGui::TableNextColumn();
                 ImGuiExt::TextFormatted("0x{0:04X}", pattern.getSize());
+            }
         }
 
         void drawCommentTooltip(const pl::ptrn::Pattern &pattern) {

Original file line number	Diff line number	Diff line change
`@@ -135,11 +135,12 @@ namespace hex::ui {`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`void drawSizeColumn(const pl::ptrn::Pattern& pattern) {`
`138`		`- ImGui::TableNextColumn();`
`139`	`138`	`if (auto bitfieldMember = dynamic_cast<const pl::ptrn::PatternBitfieldMember>(&pattern); bitfieldMember != nullptr && bitfieldMember->getParentBitfield() != nullptr)`
`140`	`139`	`drawSizeColumnForBitfieldMember(*bitfieldMember);`
`141`		`- else`
	`140`	`+ else {`
	`141`	`+ ImGui::TableNextColumn();`
`142`	`142`	`ImGuiExt::TextFormatted("0x{0:04X}", pattern.getSize());`
	`143`	`+ }`
`143`	`144`	`}`
`144`	`145`
`145`	`146`	`void drawCommentTooltip(const pl::ptrn::Pattern &pattern) {`