Skip to content

Move statistic calculation from Periodogram constructor to own function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DanielWarshofsky opened this issue Apr 17, 2025 · 0 comments · May be fixed by #3
Open

Move statistic calculation from Periodogram constructor to own function #2

DanielWarshofsky opened this issue Apr 17, 2025 · 0 comments · May be fixed by #3
Assignees
@DanielWarshofsky

Comments

@DanielWarshofsky
Copy link

periodfind/periodfind/__init__.py

Lines 239 to 248 in 03142fa

def __init__(self, periodogram, params, use_max):
self.use_max = use_max
self.data = periodogram
self.params = params
self.mean = np.mean(self.data)
self.std = np.std(self.data)
self.median = np.median(self.data)
self.mad = np.median(np.abs(self.data - self.median))

These statistics are forced to be computed whenever a Periodogram object is return. This should be changed to be optional because when frequently lists are long the time to compute these statistics can be comparable to the GPU computation time.
@DanielWarshofsky DanielWarshofsky self-assigned this Apr 17, 2025
@ejaszewski ejaszewski linked a pull request Apr 21, 2025 that will close this issue
Update __init__.py #3
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielWarshofsky DanielWarshofsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update __init__.py ZwickyTransientFacility/periodfind
1 participant
@DanielWarshofsky