Fix: issue with order 0 returning null (#75)

* fix: value being consider null if it was 0

* test: update tests

* refactor: added more coverage

Author: aaronvanston

src/helpers/CSSProperty/CSSProperty.js

@@ -13,7 +13,12 @@ export const getPropertyValue = (props, breakpoint, property) => {
 
   if (has(props, `${propertySlug}`)) {
     if (isObject(props[propertySlug])) {
-      return props[propertySlug][breakpoint] || null;
+      const value = props[propertySlug][breakpoint];
+      if (value === 0) {
+        return value.toString();
+      }
+
+      return value || null;
     }
 
     if (breakpoint === sortBreakpoints(ThemeBreakpoints)[0]) {
@@ -27,7 +32,6 @@ export const getPropertyValue = (props, breakpoint, property) => {
 
 const CSSProperty = (props, breakpoint, property) => {
   const value = getPropertyValue(props, breakpoint, property);
-
   return isNull(value) ? null : css`
     ${property}: ${value};
   `;

src/helpers/CSSProperty/CSSProperty.spec.js

@@ -31,6 +31,16 @@ describe('getPropertyValue', () => {
     const mockProps = { alignSelf: { sm: 'center' } };
     expect(getPropertyValue(mockProps, 'lg', 'align-self')).toEqual(null);
   });
+
+  test('should generate value when it is 0 (falsy)', () => {
+    const mockProps = { order: { sm: 0 } };
+    expect(getPropertyValue(mockProps, 'sm', 'order')).toEqual('0');
+  });
+
+  test('should not generate value when it is null (falsy)', () => {
+    const mockProps = { order: { sm: false } };
+    expect(getPropertyValue(mockProps, 'sm', 'order')).toEqual(null);
+  });
 });
 
 describe('CSSProperty', () => {
@@ -48,4 +58,9 @@ describe('CSSProperty', () => {
     const mockProps = { alignSelf: { sm: 'center' } };
     expect(CSSProperty(mockProps, 'sm', 'align-self').join('')).toContain('align-self: center');
   });
+
+  test('should generte order even when 0', () => {
+    const mockProps = { order: { sm: 0 } };
+    expect(CSSProperty(mockProps, 'sm', 'order').join('')).toContain('order: 0');
+  });
 });