Gotchi owner shouldn't be able to use Gotchi to Parcel their land if Gotchi is lent out #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

niveshsaharan opened this issue May 31, 2022 · 0 comments

niveshsaharan commented May 31, 2022

I was going through the smart contract code and see a potential issue here:

aavegotchi-realm-diamond/contracts/RealmDiamond/facets/AlchemicaFacet.sol

Line 304 in a9cf8d4

    
           (LibMeta.msgSender() == listing.borrower && listing.lender == s.parcels[_realmId].owner),

It seems like if the Gotchi is rented out, the owner can still use it to channel their lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment