fix: replace - with _
#246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input of action is kebab-case, but the endpoint of the rest api expects snake_case.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the inconsistent use of delimiters in permission keys by replacing dashes with underscores.
- Updated snapshot file to reflect the new permission key formatting.
- Modified the permissions extraction function to replace dashes with underscores using replaceAll.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/snapshots/index.js.md | Updated snapshot output to reflect underscore usage in keys. |
| lib/get-permissions-from-inputs.js | Adjusted key processing to convert dashes to underscores. |
parkerbxyz
approved these changes
May 3, 2025
create-app-token-action-releaser bot
pushed a commit
that referenced
this pull request
May 3, 2025
## [2.0.6](v2.0.5...v2.0.6) (2025-05-03) ### Bug Fixes * replace `-` with `_` ([#246](#246)) ([3336784](3336784))
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #245