Skip to content

Difference between text and json error is hard to understand #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Qup42 opened this issue Feb 4, 2025 · 1 comment
Open

Difference between text and json error is hard to understand #10

Qup42 opened this issue Feb 4, 2025 · 1 comment

Comments

@Qup42
Copy link
Member

Qup42 commented Feb 4, 2025

The difference between the following error cases should be made clearer in the UI:

  • an error was returned by the server as QLever JSON
  • an error was returned by the server with only a string as the response.

Most of the failures in this PR stem from this difference. Apart from the type (QUERY EXCEPTION vs UNDEFINED ERROR) (and some seemingly unrelated text changes) they look identical in the UI. This makes it very hard to understand the error from the UI.

@Qup42
Copy link
Member Author

Qup42 commented Feb 4, 2025

Extracting the error message from the JSOS is generally good, but makes the difference hard to spot in this special case.

  • adding a note, that the message was extracted from the JSON could make this clearer
  • notes what the different error messages mean/how they can occur could also clear this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant