Skip to content

[BUG] RDST admissible sampling point method returns wrong index #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
baraline opened this issue Apr 21, 2025 · 1 comment · May be fixed by #2763
Open

[BUG] RDST admissible sampling point method returns wrong index #2759

baraline opened this issue Apr 21, 2025 · 1 comment · May be fixed by #2763
Assignees
@baraline
Labels
bug Something isn't working transformations Transformations package

Comments

@baraline
Copy link
Member

baraline commented Apr 21, 2025 •
edited
Loading

Describe the bug

In RandomDilatedShapeletTransform the _get_admissible_sampling_point returns the wrong timestamp index.

Currently, the function returns:

return i, idx_choice

while it should return

return i, current_mask[i][idx_choice]

This results in some shapelets being sampled from the same point, that should have been banned from previous step, augmenting the number of duplicate shapelets that are useless for the computation, and reducing the number of "different" shapelets being sampled.

Performance analysis should be conducted before / after the fix to asses the impact.

Steps/Code to reproduce the bug

No response

Expected results

N/A

Actual results

N/A

Versions

No response
@baraline baraline added the bug Something isn't working label Apr 21, 2025
@baraline baraline self-assigned this Apr 21, 2025
@baraline baraline added the transformations Transformations package label Apr 21, 2025
@baraline
Copy link
Member Author

baraline commented Apr 26, 2025 •
edited
Loading

Image

Results are somewhat equivalent on univariate (default train/test)
Number of shapelet sampled is below the default (10k) for small datasets as expected, will push the fix.

@baraline baraline linked a pull request Apr 26, 2025 that will close this issue
[BUG] Fix RDST admissible sampling point method #2763
Open
2 tasks
@baraline baraline linked a pull request Apr 26, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baraline baraline

Labels
bug Something isn't working transformations Transformations package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Fix RDST admissible sampling point method aeon-toolkit/aeon
1 participant
@baraline