chore(backport release-1.3): fix(api): further improve branch regex (#3704)

Co-authored-by: Hidde Beydals <[email protected]>

Author: akuitybot

api/v1alpha1/generated.proto

@@ -125,7 +125,7 @@ type GitSubscription struct {
 	//
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=255
-	// +kubebuilder:validation:Pattern=`^[a-zA-Z0-9][a-zA-Z0-9._\/-]*[a-zA-Z0-9_-]$`
+	// +kubebuilder:validation:Pattern=`^[a-zA-Z0-9]([a-zA-Z0-9._\/-]*[a-zA-Z0-9_-])?$`
 	Branch string `json:"branch,omitempty" protobuf:"bytes,3,opt,name=branch"`
 	// StrictSemvers specifies whether only "strict" semver tags should be
 	// considered. A "strict" semver tag is one containing ALL of major, minor,

api/v1alpha1/warehouse_types.go

@@ -154,7 +154,7 @@ spec:
                             subscription is implicitly to the repository's default branch.
                           maxLength: 255
                           minLength: 1
-                          pattern: ^[a-zA-Z0-9][a-zA-Z0-9._\/-]*[a-zA-Z0-9_-]$
+                          pattern: ^[a-zA-Z0-9]([a-zA-Z0-9._\/-]*[a-zA-Z0-9_-])?$
                           type: string
                         commitSelectionStrategy:
                           default: NewestFromBranch

charts/kargo/resources/crds/kargo.akuity.io_warehouses.yaml

@@ -82,7 +82,7 @@
                     "description": "Branch references a particular branch of the repository. The value in this\nfield only has any effect when the CommitSelectionStrategy is\nNewestFromBranch or left unspecified (which is implicitly the same as\nNewestFromBranch). This field is optional. When left unspecified, (and the\nCommitSelectionStrategy is NewestFromBranch or unspecified), the\nsubscription is implicitly to the repository's default branch.",
                     "maxLength": 255,
                     "minLength": 1,
-                    "pattern": "^[a-zA-Z0-9][a-zA-Z0-9._\\/-]*[a-zA-Z0-9_-]$",
+                    "pattern": "^[a-zA-Z0-9]([a-zA-Z0-9._\\/-]*[a-zA-Z0-9_-])?$",
                     "type": "string"
                   },
                   "commitSelectionStrategy": {

ui/src/gen/schema/warehouses.kargo.akuity.io_v1alpha1.json

@@ -1180,7 +1180,7 @@ export type GitSubscription = Message<"github.jpy.wang.akuity.kargo.api.v1alpha1.GitS
    *
    * +kubebuilder:validation:MinLength=1
    * +kubebuilder:validation:MaxLength=255
-   * +kubebuilder:validation:Pattern=`^[a-zA-Z0-9][a-zA-Z0-9._\/-]*[a-zA-Z0-9_-]$`
+   * +kubebuilder:validation:Pattern=`^[a-zA-Z0-9]([a-zA-Z0-9._\/-]*[a-zA-Z0-9_-])?$`
    *
    * @generated from field: optional string branch = 3;
    */