feat: add new gpg signing key option in git client opts (#3893)

Signed-off-by: Kent Rancourt <[email protected]>
Co-authored-by: Faeka Ansari <[email protected]>

Author: krancour

internal/controller/git/base_repo.go

@@ -74,8 +74,11 @@ type User struct {
 	Email string
 	// SigningKeyType indicates the type of signing key.
 	SigningKeyType SigningKeyType
+	// SigningKey is an optional string containing the raw signing key content.
+	// If provided, it takes precedence over SigningKeyPath.
+	SigningKey string
 	// SigningKeyPath is an optional path referencing a signing key for
-	// signing git objects.
+	// signing git objects. Ignored if SigningKey is provided.
 	SigningKeyPath string
 }
 
@@ -107,18 +110,39 @@ func (b *baseRepo) setupAuthor(author *User) error {
 		return fmt.Errorf("error configuring git user email: %w", err)
 	}
 
-	if author.SigningKeyPath != "" && author.SigningKeyType == SigningKeyTypeGPG {
-		cmd = b.buildGitCommand("config", "--global", "commit.gpgsign", "true")
-		cmd.Dir = b.homeDir // Override the cmd.Dir that's set by r.buildGitCommand()
-		if _, err := libExec.Exec(cmd); err != nil {
-			return fmt.Errorf("error configuring commit gpg signing: %w", err)
+	if author.SigningKeyType == SigningKeyTypeGPG {
+
+		if author.SigningKey != "" {
+			author.SigningKeyPath = filepath.Join(b.homeDir, "signing-key.asc")
+			if err := os.WriteFile(
+				author.SigningKeyPath,
+				[]byte(author.SigningKey),
+				0600,
+			); err != nil {
+				return fmt.Errorf("error writing signing key to %q: %w", author.SigningKeyPath, err)
+			}
 		}
 
-		cmd = b.buildCommand("gpg", "--import", author.SigningKeyPath)
-		cmd.Dir = b.homeDir // Override the cmd.Dir that's set by r.buildCommand()
-		if _, err := libExec.Exec(cmd); err != nil {
-			return fmt.Errorf("error importing gpg key %q: %w", author.SigningKeyPath, err)
+		if author.SigningKeyPath != "" {
+			cmd = b.buildGitCommand("config", "--global", "commit.gpgsign", "true")
+			cmd.Dir = b.homeDir // Override the cmd.Dir that's set by b.buildGitCommand()
+			if _, err := libExec.Exec(cmd); err != nil {
+				return fmt.Errorf("error configuring commit gpg signing: %w", err)
+			}
+
+			cmd = b.buildCommand("gpg", "--import", author.SigningKeyPath)
+			cmd.Dir = b.homeDir // Override the cmd.Dir that's set by b.buildCommand()
+			if _, err := libExec.Exec(cmd); err != nil {
+				return fmt.Errorf("error importing gpg key %q: %w", author.SigningKeyPath, err)
+			}
 		}
+
+		if author.SigningKey != "" {
+			if err := os.Remove(author.SigningKeyPath); err != nil {
+				return fmt.Errorf("error removing file %q: %w", author.SigningKeyPath, err)
+			}
+		}
+
 	}
 
 	return nil