chore: return error if trying to access analysis run logs and not configured (#3748)

krancour · web-flow · commit da4dadd09f1a · 2025-03-28T18:08:47.000Z
Signed-off-by: Kent Rancourt &lt;kent.rancourt@gmail.com&gt;
diff --git a/internal/server/get_analysisrun_logs_v1alpha1.go b/internal/server/get_analysisrun_logs_v1alpha1.go
@@ -36,6 +36,13 @@ func (s *server) GetAnalysisRunLogs(
 		)
 	}
 
+	if s.cfg.AnalysisRunLogURLTemplate == "" {
+		return connect.NewError(
+			connect.CodeUnimplemented,
+			errors.New("AnalysisRun log streaming is not configured"),
+		)
+	}
+
 	namespace := req.Msg.GetNamespace()
 	if err := validateFieldNotEmpty("namespace", namespace); err != nil {
 		return err

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,13 @@ func (s *server) GetAnalysisRunLogs(`
`36`	`36`	`)`
`37`	`37`	`}`
`38`	`38`
	`39`	`+ if s.cfg.AnalysisRunLogURLTemplate == "" {`
	`40`	`+ return connect.NewError(`
	`41`	`+ connect.CodeUnimplemented,`
	`42`	`+ errors.New("AnalysisRun log streaming is not configured"),`
	`43`	`+ )`
	`44`	`+ }`
	`45`	`+`
`39`	`46`	`namespace := req.Msg.GetNamespace()`
`40`	`47`	`if err := validateFieldNotEmpty("namespace", namespace); err != nil {`
`41`	`48`	`return err`