Skip to content

Commit ecf4822

Browse files
jasonjoo2010sczyh30
authored andcommitted
Make SentinelConfig.loadProps() thread-safe using CopyOnWriteArraySet (#706)
1 parent 346e9b2 commit ecf4822

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

sentinel-core/src/main/java/com/alibaba/csp/sentinel/config/SentinelConfig.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.util.Map;
2121
import java.util.Properties;
2222
import java.util.concurrent.ConcurrentHashMap;
23+
import java.util.concurrent.CopyOnWriteArraySet;
2324

2425
import com.alibaba.csp.sentinel.log.LogBase;
2526
import com.alibaba.csp.sentinel.log.RecordLog;
@@ -123,7 +124,7 @@ private static void loadProps() {
123124
}
124125

125126
// JVM parameter override file config.
126-
for (Map.Entry<Object, Object> entry : System.getProperties().entrySet()) {
127+
for (Map.Entry<Object, Object> entry : new CopyOnWriteArraySet<>(System.getProperties().entrySet())) {
127128
String configKey = entry.getKey().toString();
128129
String configValue = entry.getValue().toString();
129130
String configValueOld = getConfig(configKey);

0 commit comments

Comments
 (0)