Skip to content

Support removing deprecated machines in Sentinel dashboard #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
naturalyui opened this issue Jan 23, 2019 · 2 comments
Closed

Support removing deprecated machines in Sentinel dashboard #446

naturalyui opened this issue Jan 23, 2019 · 2 comments
Labels
area/dashboard Issues or PRs about Sentinel Dashboard kind/enhancement Category issues or prs related to enhancement.

Comments

@naturalyui
Copy link

Issue Description

When I debug locally, I change the list of the console of the port console to one more line of data. At present, I can only clean up the list of machines by restarting the console, but since I have not been able to persist the rules to naocs, so every time I do It takes a lot of difficulty to re-specify the rules.

@sczyh30 sczyh30 added kind/question Category issues related to questions or problems area/dashboard Issues or PRs about Sentinel Dashboard labels Jan 24, 2019
@sczyh30 sczyh30 changed the title Is it possible to provide a way to remove the machine? Support removing deprecated machines in Sentinel dashboard Jan 28, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 28, 2019

Hi, it's necessary to provide functions for removing unused machines. We'll add interfaces and entries to it. Something to be considered:

  • Support manually remove the machine in the machine list page
  • Maybe it's necessary to support automatic removal after a machine has been marked as disconnected state for some time (this should be configurable)
  • When an application has no connected machines in machine list, this application might not be displayed in the app list (sidebar). This should also be configurable.

For a temporary solution, you can refer to this PR: #168

@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. and removed kind/question Category issues related to questions or problems labels Jan 28, 2019
@naturalyui
Copy link
Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants