Fixed detection of not-run VCR tests to exclude non-vcr tests (GoogleCloudPlatform#11863)

melinath · web-flow · commit 859f73e863c5 · 2024-09-30T14:53:25.000-07:00
diff --git a/.ci/magician/cmd/test_terraform_vcr.go b/.ci/magician/cmd/test_terraform_vcr.go
@@ -350,7 +350,7 @@ func execTestTerraformVCR(prNumber, mmCommitSha, buildID, projectID, buildStep,
 	return nil
 }
 
-var addedTestsRegexp = regexp.MustCompile(`(?m)^\+func (Test\w+)\(t \*testing.T\) {`)
+var addedTestsRegexp = regexp.MustCompile(`(?m)^\+func (TestAcc\w+)\(t \*testing.T\) {`)
 
 func notRunTests(gaDiff, betaDiff string, result vcr.Result) ([]string, []string) {
 	fmt.Println("Checking for new acceptance tests that were not run")

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ func execTestTerraformVCR(prNumber, mmCommitSha, buildID, projectID, buildStep,`
`350`	`350`	`return nil`
`351`	`351`	`}`
`352`	`352`
`353`		-var addedTestsRegexp = regexp.MustCompile(`(?m)^\+func (Test\w+)\(t \*testing.T\) {`)
	`353`	+var addedTestsRegexp = regexp.MustCompile(`(?m)^\+func (TestAcc\w+)\(t \*testing.T\) {`)
`354`	`354`
`355`	`355`	`func notRunTests(gaDiff, betaDiff string, result vcr.Result) ([]string, []string) {`
`356`	`356`	`fmt.Println("Checking for new acceptance tests that were not run")`