Skip to content

Commit d88c5f8

Browse files
alan-agius4mgechev
authored andcommitted
fix(@angular-devkit/build-angular): replace istanbul-instrumenter-loader with coverage-istanbul-loader
Fixes #16576 and fixes #7117
1 parent 5e4e5db commit d88c5f8

File tree

3 files changed

+91
-159
lines changed

3 files changed

+91
-159
lines changed

packages/angular_devkit/build_angular/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
"caniuse-lite": "1.0.30001019",
2222
"circular-dependency-plugin": "5.2.0",
2323
"clean-css": "4.2.1",
24+
"coverage-istanbul-loader": "2.0.3",
2425
"copy-webpack-plugin": "5.1.1",
2526
"core-js": "3.2.1",
2627
"file-loader": "4.2.0",
2728
"find-cache-dir": "3.0.0",
2829
"glob": "7.1.4",
29-
"istanbul-instrumenter-loader": "3.0.1",
3030
"jest-worker": "24.9.0",
3131
"karma-source-map-support": "1.4.0",
3232
"less": "3.9.0",

packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/test.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export function getTestConfig(
2929
const extraRules: webpack.Rule[] = [];
3030
const extraPlugins: webpack.Plugin[] = [];
3131

32-
// if (buildOptions.codeCoverage && CliConfig.fromProject()) {
3332
if (buildOptions.codeCoverage) {
3433
const codeCoverageExclude = buildOptions.codeCoverageExclude;
3534
const exclude: (string | RegExp)[] = [
@@ -47,8 +46,8 @@ export function getTestConfig(
4746
}
4847

4948
extraRules.push({
50-
test: /\.(js|ts)$/,
51-
loader: 'istanbul-instrumenter-loader',
49+
test: /\.(jsx?|tsx?)$/,
50+
loader: require.resolve('coverage-istanbul-loader'),
5251
options: { esModules: true },
5352
enforce: 'post',
5453
exclude,

0 commit comments

Comments
 (0)