Skip to content

feat(fxgcppubsub): Added initialization logs #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

ekkinox
Copy link
Contributor

@ekkinox ekkinox commented Jan 21, 2025

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.24%. Comparing base (3928c01) to head (582da33).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
fxgcppubsub/subscription/factory.go 25.00% 3 Missing ⚠️
fxgcppubsub/topic/factory.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   87.40%   84.24%   -3.17%     
==========================================
  Files          37       28       -9     
  Lines        1167      844     -323     
==========================================
- Hits         1020      711     -309     
+ Misses        109       99      -10     
+ Partials       38       34       -4     
Flag Coverage Δ
fxgcppubsub 84.24% <28.57%> (+0.23%) ⬆️
fxgomysqlserver ?
fxredis ?
fxslack ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekkinox ekkinox merged commit 6a1cfa7 into main Jan 21, 2025
4 checks passed
@ekkinox ekkinox deleted the feat/fxgcppubsub-logging branch January 21, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant