Removed the BuildParams::proof_generation_key function because its superceded by the ExtendedKey trait. Removed BuildParams::auth_sig because signatures can be modified after the build using the MapAuth trait.

Author: murisi

masp_primitives/src/transaction/components/sapling/builder.rs

@@ -91,10 +91,6 @@ pub struct SpendBuildParams {
     pub rcv: jubjub::Fr,
     /// The spend authorization randomizer
     pub alpha: jubjub::Fr,
-    /// The authorization signature
-    pub auth_sig: Option<Signature>,
-    /// The proof generation key
-    pub proof_generation_key: Option<ProofGenerationKey>,
 }
 
 impl BorshSerialize for SpendBuildParams {
@@ -103,10 +99,6 @@ impl BorshSerialize for SpendBuildParams {
         writer.write_all(&self.rcv.to_repr())?;
         // Write spend authorization randomizer
         writer.write_all(&self.alpha.to_repr())?;
-        // Write the authorization signature
-        self.auth_sig.serialize(writer)?;
-        // Write the proof generation key
-        self.proof_generation_key.serialize(writer)?;
         Ok(())
     }
 }
@@ -123,16 +115,10 @@ impl BorshDeserialize for SpendBuildParams {
         let alpha = Option::from(jubjub::Fr::from_bytes(&alpha_bytes)).ok_or_else(|| {
             std::io::Error::new(std::io::ErrorKind::InvalidData, "alpha not in field")
         })?;
-        // Read the authorization signature
-        let auth_sig = Option::<Signature>::deserialize_reader(reader)?;
-        // Read the proof generation key
-        let proof_generation_key = Option::<ProofGenerationKey>::deserialize_reader(reader)?;
         // Finally, aggregate the spend parameters
         Ok(SpendBuildParams {
             rcv,
             alpha,
-            auth_sig,
-            proof_generation_key,
         })
     }
 }
@@ -347,8 +333,6 @@ impl<R: CryptoRng + RngCore> RngBuildParams<R> {
         self.spends.entry(i).or_insert_with(|| SpendBuildParams {
             rcv: jubjub::Fr::random(&mut self.rng),
             alpha: jubjub::Fr::random(&mut self.rng),
-            auth_sig: None,
-            proof_generation_key: None,
         })
     }