Skip to content

Commit 17e3fd0

Browse files
committed
url: set formatUrl method as no side effect
PR-URL: nodejs#46884 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent efdd768 commit 17e3fd0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_url.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ void Initialize(Local<Object> target,
313313
void* priv) {
314314
SetMethod(context, target, "parse", Parse);
315315
SetMethod(context, target, "updateUrl", UpdateUrl);
316-
SetMethod(context, target, "formatUrl", FormatUrl);
316+
SetMethodNoSideEffect(context, target, "formatUrl", FormatUrl);
317317

318318
SetMethodNoSideEffect(context, target, "domainToASCII", DomainToASCII);
319319
SetMethodNoSideEffect(context, target, "domainToUnicode", DomainToUnicode);

0 commit comments

Comments
 (0)