Add support for parameter manager parameter version resource google_parameter_manager_parameter_version (GoogleCloudPlatform#12641)

Author: abheda-crest

mmv1/products/parametermanager/ParameterVersion.yaml

@@ -0,0 +1,110 @@
+# Copyright 2024 Google Inc.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+---
+name: 'ParameterVersion'
+description: |
+  A Parameter Version resource that stores the actual value of the parameter.
+min_version: 'beta'
+references:
+  guides:
+  api: 'https://cloud.google.com/secret-manager/parameter-manager/docs/reference/rest/v1/projects.locations.parameters.versions'
+docs:
+base_url: '{{parameter}}/versions'
+self_link: '{{parameter}}/versions/{{parameter_version_id}}'
+create_url: '{{parameter}}/versions?parameter_version_id={{parameter_version_id}}'
+update_verb: 'PATCH'
+update_mask: true
+import_format:
+  - 'projects/{{%project}}/locations/global/parameters/{{%parameter_id}}/versions/{{%parameter_version_id}}'
+timeouts:
+  insert_minutes: 20
+  update_minutes: 20
+  delete_minutes: 20
+examples:
+  - name: 'parameter_version_basic'
+    primary_resource_id: 'parameter-version-basic'
+    min_version: 'beta'
+    vars:
+      parameter_id: 'parameter'
+      parameter_version_id: 'parameter_version'
+  - name: 'parameter_version_with_json_format'
+    primary_resource_id: 'parameter-version-with-json-format'
+    min_version: 'beta'
+    vars:
+      parameter_id: 'parameter'
+      parameter_version_id: 'parameter_version'
+  - name: 'parameter_version_with_yaml_format'
+    primary_resource_id: 'parameter-version-with-yaml-format'
+    min_version: 'beta'
+    vars:
+      parameter_id: 'parameter'
+      parameter_version_id: 'parameter_version'
+custom_code:
+  custom_import: 'templates/terraform/custom_import/parameter_manager_parameter_version.go.tmpl'
+parameters:
+  - name: 'parameter'
+    type: ResourceRef
+    description: |
+      Parameter Manager Parameter resource.
+    url_param_only: true
+    required: true
+    immutable: true
+    resource: 'Parameter'
+    imports: 'name'
+  - name: 'parameter_version_id'
+    type: String
+    description: |
+      Version ID of the Parameter Version Resource. This must be unique within the Parameter.
+    url_param_only: true
+    required: true
+    immutable: true
+properties:
+  - name: 'name'
+    type: String
+    description: |
+      The resource name of the Parameter Version. Format:
+      `projects/{{project}}/locations/global/parameters/{{parameter_id}}/versions/{{parameter_version_id}}`
+    output: true
+  - name: 'createTime'
+    type: String
+    description: |
+      The time at which the Parameter Version was created.
+    output: true
+  - name: 'updateTime'
+    type: String
+    description: |
+      The time at which the Parameter Version was updated.
+    output: true
+  - name: 'disabled'
+    type: Boolean
+    description: |
+      The current state of Parameter Version. This field is only applicable for updating Parameter Version.
+  - name: 'payload'
+    type: NestedObject
+    description: |
+      The payload content of a ParameterVersion resource.
+    flatten_object: true
+    required: true
+    immutable: true
+    custom_flatten: 'templates/terraform/custom_flatten/parameter_version_parameter_data.go.tmpl'
+    properties:
+      - name: 'parameter_data'
+        type: String
+        description: |
+          The Parameter data.
+        api_name: data
+        required: true
+        immutable: true
+        sensitive: true
+        custom_expand: 'templates/terraform/custom_expand/base64.go.tmpl'

mmv1/products/parametermanagerregional/RegionalParameterVersion.yaml

@@ -45,18 +45,12 @@ examples:
     vars:
       parameter_id: 'regional_parameter'
       parameter_version_id: 'regional_parameter_version'
-      data: 'parameter_data_json_format.yaml'
-    test_vars_overrides:
-      'data': '"./test-fixtures/parameter_data_json_format.json"'
   - name: 'regional_parameter_version_with_yaml_format'
     primary_resource_id: 'regional-parameter-version-with-yaml-format'
     min_version: 'beta'
     vars:
       parameter_id: 'regional_parameter'
       parameter_version_id: 'regional_parameter_version'
-      data: 'parameter_data_yaml_format.yaml'
-    test_vars_overrides:
-      'data': '"./test-fixtures/parameter_data_yaml_format.yaml"'
 custom_code:
   pre_create: 'templates/terraform/pre_create/parameter_manager_regional_parameter_version.go.tmpl'
   custom_import: 'templates/terraform/custom_import/parameter_manager_regional_parameter_version.go.tmpl'

mmv1/templates/terraform/custom_import/parameter_manager_parameter_version.go.tmpl

@@ -0,0 +1,38 @@
+{{/*
+	The license inside this block applies to this file
+	Copyright 2024 Google Inc.
+	Licensed under the Apache License, Version 2.0 (the "License");
+	you may not use this file except in compliance with the License.
+	You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+	Unless required by applicable law or agreed to in writing, software
+	distributed under the License is distributed on an "AS IS" BASIS,
+	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+	See the License for the specific language governing permissions and
+	limitations under the License.
+*/ -}}
+	config := meta.(*transport_tpg.Config)
+
+    // current import_formats can't import fields with forward slashes in their value
+	if err := tpgresource.ParseImportId([]string{"(?P<name>.+)"}, d, config); err != nil {
+		return nil, err
+	}
+
+	name := d.Get("name").(string)
+	parameterRegex := regexp.MustCompile("(projects/.+/locations/global/parameters/.+)/versions/.+$")
+	versionRegex := regexp.MustCompile("projects/(.+)/locations/global/parameters/(.+)/versions/(.+)$")
+
+	parts := parameterRegex.FindStringSubmatch(name)
+	if len(parts) != 2 {
+		return nil, fmt.Errorf("Version name does not fit the format `projects/{{"{{"}}project{{"}}"}}/locations/global/parameters/{{"{{"}}parameter_id{{"}}"}}/versions/{{"{{"}}parameter_version_id{{"}}"}}`")
+	}
+	if err := d.Set("parameter", parts[1]); err != nil {
+		return nil, fmt.Errorf("Error setting parameter: %s", err)
+	}
+
+	parts = versionRegex.FindStringSubmatch(name)
+    
+	if err := d.Set("parameter_version_id", parts[3]); err != nil {
+		return nil, fmt.Errorf("Error setting parameter_version_id: %s", err)
+	}
+
+	return []*schema.ResourceData{d}, nil

mmv1/templates/terraform/examples/parameter_version_basic.tf.tmpl

@@ -0,0 +1,11 @@
+resource "google_parameter_manager_parameter" "parameter-basic" {
+  provider = google-beta
+  parameter_id = "{{index $.Vars "parameter_id"}}"
+}
+
+resource "google_parameter_manager_parameter_version" "{{$.PrimaryResourceId}}" {
+  provider = google-beta
+  parameter = google_parameter_manager_parameter.parameter-basic.id
+  parameter_version_id = "{{index $.Vars "parameter_version_id"}}"
+  parameter_data = "app-parameter-version-data"
+}

mmv1/templates/terraform/examples/parameter_version_with_json_format.tf.tmpl

@@ -0,0 +1,15 @@
+resource "google_parameter_manager_parameter" "parameter-basic" {
+  provider = google-beta
+  parameter_id = "{{index $.Vars "parameter_id"}}"
+  format = "JSON"
+}
+
+resource "google_parameter_manager_parameter_version" "{{$.PrimaryResourceId}}" {
+  provider = google-beta
+  parameter = google_parameter_manager_parameter.parameter-basic.id
+  parameter_version_id = "{{index $.Vars "parameter_version_id"}}"
+  parameter_data = jsonencode({
+    "key1": "val1",
+    "key2": "val2"
+  })
+}

mmv1/templates/terraform/examples/parameter_version_with_yaml_format.tf.tmpl

@@ -0,0 +1,15 @@
+resource "google_parameter_manager_parameter" "parameter-basic" {
+  provider = google-beta
+  parameter_id = "{{index $.Vars "parameter_id"}}"
+  format = "YAML"
+}
+
+resource "google_parameter_manager_parameter_version" "{{$.PrimaryResourceId}}" {
+  provider = google-beta
+  parameter = google_parameter_manager_parameter.parameter-basic.id
+  parameter_version_id = "{{index $.Vars "parameter_version_id"}}"
+  parameter_data = yamlencode({
+    "key1": "val1",
+    "key2": "val2"
+  })
+}

mmv1/templates/terraform/examples/regional_parameter_version_with_json_format.tf.tmpl

@@ -9,5 +9,8 @@ resource "google_parameter_manager_regional_parameter_version" "{{$.PrimaryResou
   provider = google-beta
   parameter = google_parameter_manager_regional_parameter.regional-parameter-basic.id
   parameter_version_id = "{{index $.Vars "parameter_version_id"}}"
-  parameter_data = file("{{index $.Vars "data"}}")
+  parameter_data = jsonencode({
+    "key1": "val1",
+    "key2": "val2"
+  })
 }

mmv1/templates/terraform/examples/regional_parameter_version_with_yaml_format.tf.tmpl

@@ -9,5 +9,8 @@ resource "google_parameter_manager_regional_parameter_version" "{{$.PrimaryResou
   provider = google-beta
   parameter = google_parameter_manager_regional_parameter.regional-parameter-basic.id
   parameter_version_id = "{{index $.Vars "parameter_version_id"}}"
-  parameter_data = file("{{index $.Vars "data"}}")
+  parameter_data = yamlencode({
+    "key1": "val1",
+    "key2": "val2"
+  })
 }

mmv1/third_party/terraform/services/parametermanager/resource_parameter_manager_parameter_version_test.go.tmpl

@@ -0,0 +1,87 @@
+package parametermanager_test
+{{- if ne $.TargetVersionName "ga" }}
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-provider-google/google/acctest"
+)
+
+func TestAccParameterManagerParameterVersion_update(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
+		CheckDestroy:             testAccCheckParameterManagerParameterVersionDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccParameterManagerParameterVersion_basic(context),
+			},
+			{
+				ResourceName:            "google_parameter_manager_parameter_version.parameter-version-update",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"parameter", "parameter_version_id"},
+			},
+			{
+				Config: testAccParameterManagerParameterVersion_update(context),
+			},
+			{
+				ResourceName:            "google_parameter_manager_parameter_version.parameter-version-update",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"parameter", "parameter_version_id"},
+			},
+			{
+				Config: testAccParameterManagerParameterVersion_basic(context),
+			},
+			{
+				ResourceName:            "google_parameter_manager_parameter_version.parameter-version-update",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"parameter", "parameter_version_id"},
+			},
+		},
+	})
+}
+
+func testAccParameterManagerParameterVersion_basic(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_parameter_manager_parameter" "parameter-update" {
+  provider = google-beta
+  parameter_id = "tf_test_parameter%{random_suffix}"
+}
+
+resource "google_parameter_manager_parameter_version" "parameter-version-update" {
+  provider = google-beta
+  parameter = google_parameter_manager_parameter.parameter-update.id
+  parameter_version_id = "tf_test_parameter_version%{random_suffix}"
+  parameter_data = "parameter-version-data"
+}
+`, context)
+}
+
+func testAccParameterManagerParameterVersion_update(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_parameter_manager_parameter" "parameter-update" {
+  provider = google-beta
+  parameter_id = "tf_test_parameter%{random_suffix}"
+}
+
+resource "google_parameter_manager_parameter_version" "parameter-version-update" {
+  provider = google-beta
+  parameter = google_parameter_manager_parameter.parameter-update.id
+  parameter_version_id = "tf_test_parameter_version%{random_suffix}"
+  parameter_data = "parameter-version-data"
+  disabled = true
+}
+`, context)
+}
+
+{{ end }}