Move task_to_str to Task class

Partial: #4548

Author: ssbarnea

src/ansiblelint/rules/__init__.py

@@ -108,7 +108,7 @@ def _enrich_matcherror_with_task_details(
     ) -> None:
         match.task = task
         if not match.details:
-            match.details = "Task/Handler: " + ansiblelint.utils.task_to_str(task)
+            match.details = "Task/Handler: " + str(task)
 
         match.lineno = max(match.lineno, task[LINE_NUMBER_KEY])
 

src/ansiblelint/utils.py

@@ -712,37 +712,6 @@ def normalize_task_v2(task: Task) -> dict[str, Any]:
     return result
 
 
-def task_to_str(task: dict[str, Any]) -> str:
-    """Make a string identifier for the given task."""
-    name = task.get("name")
-    if name:
-        return str(name)
-    action = task.get("action")
-    if isinstance(action, str) or not isinstance(action, dict):
-        return str(action)
-    args = [
-        f"{k}={v}"
-        for (k, v) in action.items()
-        if k
-        not in [
-            "__ansible_module__",
-            "__ansible_module_original__",
-            "_raw_params",
-            LINE_NUMBER_KEY,
-            FILENAME_KEY,
-        ]
-    ]
-
-    raw_params = action.get("_raw_params", [])
-    if isinstance(raw_params, list):
-        for item in raw_params:
-            args.extend(str(item))
-    else:
-        args.append(raw_params)
-
-    return f"{action['__ansible_module__']} {' '.join(args)}"
-
-
 # pylint: disable=too-many-nested-blocks
 def extract_from_list(  # type: ignore[no-any-unimported]
     blocks: AnsibleBaseYAMLObject,

test/test_utils.py

@@ -281,7 +281,7 @@ def test_template(template: str, output: str) -> None:
 def test_task_to_str_unicode() -> None:
     """Ensure that extracting messages from tasks preserves Unicode."""
     task = utils.Task({"fail": {"msg": "unicode é ô à"}}, filename="filename.yml")
-    result = utils.task_to_str(task._normalize_task())  # noqa: SLF001
+    result = str(utils.Task(task._normalize_task()))  # noqa: SLF001
     assert result == "fail msg=unicode é ô à"