Improve results with broken multiline playbooks

- Reduce the logged exceptions caused by invalid data
- Reduce number of errors cased by the same root cause

Fixes: #4492

Author: ssbarnea

.config/constraints.txt

@@ -1,5 +1,5 @@
 # This file was autogenerated by uv via the following command:
-#    tox run deps
+#    tox run -e deps
 ansible-compat==25.1.1    # via ansible-lint (pyproject.toml)
 astroid==3.3.8            # via pylint
 attrs==25.1.0             # via jsonschema, referencing
@@ -92,7 +92,6 @@ regex==2024.11.6          # via mkdocs-material
 requests==2.32.3          # via linkchecker, mkdocs-htmlproofer-plugin, mkdocs-material
 rpds-py==0.22.3           # via jsonschema, referencing
 ruamel-yaml==0.18.10      # via ansible-lint (pyproject.toml)
-ruamel-yaml-clib==0.2.12  # via ruamel-yaml, ansible-lint (pyproject.toml)
 setproctitle==1.3.4       # via pytest-xdist
 six==1.17.0               # via python-dateutil
 soupsieve==2.6            # via beautifulsoup4
@@ -119,4 +118,5 @@ zipp==3.21.0              # via importlib-metadata
 # ansible-core
 # pip
 # resolvelib
+# ruamel-yaml-clib
 # uv

.config/requirements-lock.txt

@@ -1,5 +1,5 @@
 # This file was autogenerated by uv via the following command:
-#    tox run deps
+#    tox run -e deps
 ansible-compat==25.1.1    # via ansible-lint (pyproject.toml)
 attrs==25.1.0             # via jsonschema, referencing
 black==25.1.0             # via ansible-lint (pyproject.toml)
@@ -22,7 +22,6 @@ pyyaml==6.0.2             # via ansible-compat, ansible-core, yamllint, ansible-
 referencing==0.36.2       # via jsonschema, jsonschema-specifications, ansible-lint (pyproject.toml)
 rpds-py==0.22.3           # via jsonschema, referencing
 ruamel-yaml==0.18.10      # via ansible-lint (pyproject.toml)
-ruamel-yaml-clib==0.2.12  # via ruamel-yaml
 subprocess-tee==0.4.2     # via ansible-compat, ansible-lint (pyproject.toml)
 tomli==2.2.1              # via black
 typing-extensions==4.12.2  # via black, referencing
@@ -33,3 +32,4 @@ zipp==3.21.0              # via importlib-metadata
 # The following packages were excluded from the output:
 # ansible-core
 # resolvelib
+# ruamel-yaml-clib

.github/workflows/tox.yml

@@ -134,7 +134,7 @@ jobs:
       - name: Install tox
         run: |
           python3 -m pip install --upgrade pip
-          python3 -m pip install --upgrade "tox>=4.0.0" "tox-uv>=1.16.0" uv
+          python3 -m pip install --upgrade "tox>=4.0.0" "tox-uv>=1.20.2" uv
 
       - name: Log installed dists
         run: python3 -m pip freeze --all

.pre-commit-config.yaml

@@ -14,8 +14,6 @@ exclude: >
   (?x)^(
     .config/constraints.txt|
     .config/.*requirements.*|
-    .vscode/extensions.json|
-    .vscode/settings.json|
     examples/broken/encoding.yml|
     examples/broken/encoding.j2|
     examples/broken/yaml-with-tabs/invalid-due-tabs.yaml|
@@ -31,9 +29,9 @@ repos:
   - repo: meta
     hooks:
       - id: check-useless-excludes
-  - repo: https://github.com/pre-commit/mirrors-prettier
+  - repo: https://github.com/rbubley/mirrors-prettier
     # keep it before yamllint
-    rev: v4.0.0-alpha.8
+    rev: v3.4.2
     hooks:
       - id: prettier
         # Temporary excludes so we can gradually normalize the formatting
@@ -76,6 +74,11 @@ repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks.git
     rev: v5.0.0
     hooks:
+      - id: check-added-large-files
+      - id: check-merge-conflict
+      - id: check-symlinks
+      - id: debug-statements
+      - id: detect-private-key
       - id: end-of-file-fixer
         # ignore formatting-prettier to have an accurate prettier comparison
         exclude: >
@@ -133,6 +136,12 @@ repos:
     rev: v0.24.2
     hooks:
       - id: toml-sort-fix
+
+  - repo: https://github.com/tox-dev/tox-ini-fmt
+    rev: 1.5.0
+    hooks:
+      - id: tox-ini-fmt
+
   - repo: https://github.com/astral-sh/ruff-pre-commit
     rev: v0.9.3
     hooks:
@@ -143,10 +152,6 @@ repos:
         types_or: [python, pyi]
       # - id: ruff-format # must be after ruff
       #   types_or: [python, pyi]
-  - repo: https://github.com/psf/black # must be after ruff
-    rev: 25.1.0
-    hooks:
-      - id: black
   - repo: https://github.com/pre-commit/mirrors-mypy
     rev: v1.14.1
     hooks:
@@ -242,33 +247,34 @@ repos:
         # stages: [manual]
       - id: deps
         name: Upgrade constraints files and requirements
-        files: ^(pyproject\.toml|requirements\.txt)$
+        files: ^(pyproject\.toml|.config/.*)$
+        always_run: true
         language: python
         language_version: "3.10" # minimal we support officially
         entry: python3 -m uv pip compile -q --all-extras --output-file=.config/constraints.txt pyproject.toml --upgrade
         pass_filenames: false
         stages:
           - manual
         additional_dependencies:
-          - uv>=0.4.3
+          - uv>=0.5.21
       - id: pip-compile
         name: Check constraints files and requirements
-        files: ^(pyproject\.toml|requirements\.txt)$
+        files: ^(pyproject\.toml|\.config/.*)$
         language: python
         language_version: "3.10" # minimal we support officially
         entry: python3 -m uv pip compile -q --all-extras --output-file=.config/constraints.txt pyproject.toml
         pass_filenames: false
         additional_dependencies:
-          - uv>=0.4.3
+          - uv>=0.5.21
       - id: lock
         name: Update requirements-lock.txt
         alias: lock
         always_run: true
         entry: python3 -m uv pip compile -q --upgrade --output-file=.config/requirements-lock.txt pyproject.toml --strip-extras
-        files: ^.config\/.*requirements.*$
+        files: ^(pyproject\.toml|\.config/.*)$
         language: python
         language_version: "3.10" # minimal we support officially
         pass_filenames: false
         stages: [manual]
         additional_dependencies:
-          - uv>=0.4.3
+          - uv>=0.5.21

.vscode/extensions.json

@@ -1,22 +1,22 @@
 {
-    "recommendations": [
-        "Tyriar.sort-lines",
-        "charliermarsh.ruff",
-        "esbenp.prettier-vscode",
-        "hbenl.vscode-test-explorer",
-        "ms-python.black-formatter",
-        "ms-python.isort",
-        "ms-python.mypy-type-checker",
-        "ms-python.pylint",
-        "ms-python.python",
-        "ms-python.vscode-pylance",
-        "ms-vscode.live-server",
-        "redhat.ansible",
-        "redhat.vscode-yaml",
-        "ryanluker.vscode-coverage-gutters",
-        "shardulm94.trailing-spaces",
-        "tamasfe.even-better-toml",
-        "timonwong.shellcheck",
-        "znck.grammarly",
-    ]
+  "recommendations": [
+    "Tyriar.sort-lines",
+    "charliermarsh.ruff",
+    "esbenp.prettier-vscode",
+    "hbenl.vscode-test-explorer",
+    "ms-python.black-formatter",
+    "ms-python.isort",
+    "ms-python.mypy-type-checker",
+    "ms-python.pylint",
+    "ms-python.python",
+    "ms-python.vscode-pylance",
+    "ms-vscode.live-server",
+    "redhat.ansible",
+    "redhat.vscode-yaml",
+    "ryanluker.vscode-coverage-gutters",
+    "shardulm94.trailing-spaces",
+    "tamasfe.even-better-toml",
+    "timonwong.shellcheck",
+    "znck.grammarly"
+  ]
 }

.vscode/settings.json

@@ -1,54 +1,46 @@
 {
-    "[markdown]": {
-        "editor.defaultFormatter": "esbenp.prettier-vscode"
+  "[markdown]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
+  },
+  "editor.formatOnSave": true,
+  "evenBetterToml.formatter.allowedBlankLines": 2,
+  "files.exclude": {
+    "*.egg-info": true,
+    ".pytest_cache": true,
+    ".tox": true,
+    "__pycache__": true,
+    "build": true
+  },
+  "git.ignoreLimitWarning": true,
+  "grammarly.config.documentDomain": "academic",
+  "grammarly.files.include": ["**/*.txt", "**/*.md"],
+  "python.experiments.optInto": ["pythonTestAdapter"],
+  "python.terminal.activateEnvironment": true,
+  "python.testing.pytestEnabled": true,
+  "python.testing.unittestEnabled": false,
+  "mypy-type-checker.severity": {
+    "error": "Warning"
+  },
+  "sortLines.filterBlankLines": true,
+  "yaml.completion": true,
+  "yaml.customTags": ["!encrypted/pkcs1-oaep scalar", "!vault scalar"],
+  "yaml.format.enable": false,
+  "yaml.validate": true,
+  "evenBetterToml.formatter.alignComments": false,
+  "[python]": {
+    "editor.codeActionsOnSave": {
+      "source.organizeImports": "explicit",
+      "source.fixAll": "explicit"
     },
-    "editor.formatOnSave": true,
-    "evenBetterToml.formatter.allowedBlankLines": 2,
-    "files.exclude": {
-        "*.egg-info": true,
-        ".pytest_cache": true,
-        ".tox": true,
-        "__pycache__": true,
-        "build": true
-    },
-    "git.ignoreLimitWarning": true,
-    "grammarly.config.documentDomain": "academic",
-    "grammarly.files.include": [
-        "**/*.txt",
-        "**/*.md"
-    ],
-    "python.experiments.optInto": [
-        "pythonTestAdapter"
-    ],
-    "python.terminal.activateEnvironment": true,
-    "python.testing.pytestEnabled": true,
-    "python.testing.unittestEnabled": false,
-    "mypy-type-checker.severity": {
-        "error": "Warning",
-    },
-    "sortLines.filterBlankLines": true,
-    "yaml.completion": true,
-    "yaml.customTags": [
-        "!encrypted/pkcs1-oaep scalar",
-        "!vault scalar"
-    ],
-    "yaml.format.enable": false,
-    "yaml.validate": true,
-    "evenBetterToml.formatter.alignComments": false,
-    "[python]": {
-        "editor.codeActionsOnSave": {
-            "source.organizeImports": "explicit",
-            "source.fixAll": "explicit"
-        },
-        "editor.defaultFormatter": "ms-python.black-formatter",
-        "editor.formatOnSave": true
-    },
-    "evenBetterToml.formatter.arrayTrailingComma": true,
-    "[toml]": {
-        "editor.defaultFormatter": "panekj.even-betterer-toml"
-    },
-    "sonarlint.connectedMode.project": {
-        "connectionId": "ansible",
-        "projectKey": "ansible_ansible-lint"
-    }
+    "editor.defaultFormatter": "charliermarsh.ruff",
+    "editor.formatOnSave": true
+  },
+  "evenBetterToml.formatter.arrayTrailingComma": true,
+  "[toml]": {
+    "editor.defaultFormatter": "panekj.even-betterer-toml"
+  },
+  "sonarlint.connectedMode.project": {
+    "connectionId": "ansible",
+    "projectKey": "ansible_ansible-lint"
+  }
 }

cspell.config.yaml

@@ -21,3 +21,4 @@ ignorePaths:
   - src/ansiblelint/schemas/*.json
   # Other
   - "*.svg"
+  - ".vscode/**"

pyproject.toml

@@ -50,9 +50,6 @@ documentation = "https://ansible.readthedocs.io/projects/lint/"
 homepage = "https://github.com/ansible/ansible-lint"
 repository = "https://github.com/ansible/ansible-lint"
 
-[tool.black]
-target-version = ["py310"]
-
 [tool.codespell]
 # indention is a typo in ruamel.yaml's API
 ignore-words-list = "indention"
@@ -332,22 +329,18 @@ git_describe_command = [
   "v*.*"
 ]
 local_scheme = "no-local-version"
-tag_regex = "^(?P<prefix>v)?(?P<version>[0-9.]+)(?P<suffix>.*)?$"
+tag_regex = "^(?P<prefix>v)?(?P<version>\\d+[^\\+]*)(?P<suffix>.*)?$"
 write_to = "src/ansiblelint/_version.py"
 
 [tool.tomlsort]
 in_place = true
 sort_inline_tables = true
 sort_table_keys = true
 
-[tool.uv]
-# incompatible with Windows
-environments = ["platform_system != 'Windows'"]
-
 [tool.uv.pip]
 annotation-style = "line"
-custom-compile-command = "tox run deps"
-no-emit-package = ["ansible-core", "pip", "resolvelib", "uv"]
+custom-compile-command = "tox run -e deps"
+no-emit-package = ["ansible-core", "pip", "resolvelib", "ruamel-yaml-clib", "uv"]
 
 [tool.vulture]
 exclude = [

src/ansiblelint/__main__.py

@@ -280,6 +280,9 @@ def main(argv: list[str] | None = None) -> int:
     if argv is None:  # pragma: no cover
         argv = sys.argv
 
+    warnings.simplefilter(
+        "ignore", ResourceWarning
+    )  # suppress "enable tracemalloc to get the object allocation traceback"
     with warnings.catch_warnings(record=True) as warns:
         # do not use "ignore" as we will miss to collect them
         warnings.simplefilter(action="default")

src/ansiblelint/file_utils.py

@@ -407,7 +407,8 @@ def is_owned_by_ansible(self) -> bool:
     def failed(self) -> bool:
         """Return true if we already found syntax-check errors on this file."""
         return any(
-            match.rule.id in ("syntax-check", "load-failure") for match in self.matches
+            match.rule.id in ("syntax-check", "load-failure", "internal-error")
+            for match in self.matches
         )
 
     @property

src/ansiblelint/rules/__init__.py

@@ -241,8 +241,8 @@ def matchyaml(self, file: Lintable) -> list[MatchError]:
             yaml = [yaml]
 
         for play in yaml:
-            # Bug #849
-            if play is None:
+            # Bug #849 and #4492
+            if play is None or not hasattr(play, "get"):
                 continue
 
             if self.id in play.get(SKIPPED_RULES_KEY, ()):