-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44188: [Python] Fix pandas roundtrip with bytes column names #44171
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@Piong1997 do you have a reproducible example that shows the bug? (it would be good to add a test for it) |
Note that this bug can only be reproduced in pandas 2.0 or above. |
Thanks, that indeed errors right now. Could you add that as a test case in |
I have already added the case |
|
1 similar comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @Piong1997 ! I rebased and will merge if CI is green.
@github-actions crossbow submit pandas |
Revision: e619630 Submitted crossbow builds: ursacomputing/crossbow @ actions-690c1f2da2 |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e2ac52d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
@github-actions crossbow submit wheel-windows-cp310-cp310-amd64 |
Revision: e619630 Submitted crossbow builds: ursacomputing/crossbow @ actions-a92b6e4575
|
Rationale for this change
There is a bug that when column dtype is np.bytes,it will goto the final branch and run level=level.astype(dtype)
Are these changes tested?
Yes