Skip to content

Commit 2acc9cc

Browse files
authored
Reenable PreCommit Flink Container after Fix cleanup scripts (#33957)
* Revert "Disable PreCommit Flink Container (#33956)" This reverts commit 7ac5bc4. * Fix clean up scripts * Fix trigger paths * Fix script
1 parent 7ac5bc4 commit 2acc9cc

7 files changed

+22
-14
lines changed

.github/autolabeler.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ io: ["sdks/go/pkg/beam/io/**/*", "sdks/java/io/**/*", "sdks/python/apache_beam/
7979

8080
# Runners
8181
"runners": ["runners/**/*", "sdks/go/pkg/beam/runners/**/*", "sdks/python/apache_beam/runners/**/*", "sdks/typescript/src/apache_beam/runners/**/*"]
82-
"core": ["runners/core-construction-java/**/*", "runners/core-java/**/*"]
82+
"core": ["runners/core-java/**/*"]
8383
"dataflow": ["runners/google-cloud-dataflow-java/**/*", "sdks/go/pkg/beam/runners/dataflow/**/*", "sdks/python/runners/dataflow/**/*"]
8484
"direct": ["runners/direct-java/**/*", "sdks/go/pkg/beam/runners/direct/**/*", "sdks/python/runners/direct/**/*"]
8585
"flink": ["runners/flink/**/*", "sdks/go/pkg/beam/runners/flink/**/*"]

.github/workflows/beam_PreCommit_Flink_Container.yml

+18-1
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,27 @@ name: PreCommit Flink Container
1717

1818
on:
1919
pull_request_target:
20-
# TODO(https://github.com/apache/beam/pull/33956) re-enable when two issues resolved.
2120
paths:
21+
- 'model/**'
22+
- 'sdks/python/apache_beam/runners/portability/**'
23+
- 'release/**'
24+
- 'runners/core-java/**'
25+
- 'runners/flink/**'
26+
- 'runners/java-fn-execution/**'
2227
- '.github/trigger_files/beam_PreCommit_Flink_Container.json'
2328
- 'release/trigger_all_tests.json'
29+
push:
30+
tags: [ 'v*' ]
31+
branches: [ 'master', 'release-*' ]
32+
paths:
33+
- 'model/**'
34+
- 'sdks/python/apache_beam/runners/portability/**'
35+
- 'release/**'
36+
- 'runners/core-java/**'
37+
- 'runners/flink/**'
38+
- 'runners/java-fn-execution/**'
39+
schedule:
40+
- cron: '0 */6 * * *'
2441
workflow_dispatch:
2542

2643
# Setting explicit permissions for the action to avoid the default permissions which are `write-all`

.github/workflows/beam_PreCommit_Java_GCP_IO_Direct.yml

-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ on:
2020
tags: ['v*']
2121
branches: ['master', 'release-*']
2222
paths:
23-
- "runners/core-construction-java/**"
2423
- "runners/core-java/**"
2524
- "sdks/java/core/src/main/**"
2625
- "sdks/java/extensions/arrow/**"
@@ -34,7 +33,6 @@ on:
3433
pull_request_target:
3534
branches: ['master', 'release-*']
3635
paths:
37-
- "runners/core-construction-java/**"
3836
- "runners/core-java/**"
3937
- 'release/trigger_all_tests.json'
4038
- '.github/trigger_files/beam_PreCommit_Java_GCP_IO_Direct.json'

.github/workflows/beam_PreCommit_Portable_Python.yml

-4
Original file line numberDiff line numberDiff line change
@@ -21,25 +21,21 @@ on:
2121
branches: ['master', 'release-*']
2222
paths:
2323
- 'model/**'
24-
- 'runners/core-construction-java/**'
2524
- 'runners/core-java/**'
2625
- 'runners/extensions-java/**'
2726
- 'runners/flink/**'
2827
- 'runners/java-fn-execution/**'
29-
- 'runners/reference/**'
3028
- 'sdks/python/**'
3129
- 'release/**'
3230
- '.github/workflows/beam_PreCommit_Portable_Python.yml'
3331
pull_request_target:
3432
branches: ['master', 'release-*']
3533
paths:
3634
- 'model/**'
37-
- 'runners/core-construction-java/**'
3835
- 'runners/core-java/**'
3936
- 'runners/extensions-java/**'
4037
- 'runners/flink/**'
4138
- 'runners/java-fn-execution/**'
42-
- 'runners/reference/**'
4339
- 'sdks/python/**'
4440
- 'release/**'
4541
- 'release/trigger_all_tests.json'

.github/workflows/beam_PreCommit_Python_PVR_Flink.yml

-4
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ on:
2323
- 'sdks/python/**'
2424
- 'release/**'
2525
- 'sdks/java/io/kafka/**'
26-
- 'runners/core-construction-java/**'
2726
- 'runners/core-java/**'
2827
- 'runners/extensions-java/**'
2928
- 'runners/flink/**'
3029
- 'runners/java-fn-execution/**'
31-
- 'runners/reference/**'
3230
- 'release/trigger_all_tests.json'
3331
- '.github/trigger_files/beam_PreCommit_Python_PVR_Flink.json'
3432
issue_comment:
@@ -41,12 +39,10 @@ on:
4139
- 'sdks/python/**'
4240
- 'release/**'
4341
- 'sdks/java/io/kafka/**'
44-
- 'runners/core-construction-java/**'
4542
- 'runners/core-java/**'
4643
- 'runners/extensions-java/**'
4744
- 'runners/flink/**'
4845
- 'runners/java-fn-execution/**'
49-
- 'runners/reference/**'
5046
- '.github/workflows/beam_PreCommit_Python_PVR_Flink.yml'
5147
schedule:
5248
- cron: '45 2/6 * * *'

.test-infra/dataproc/cleanup.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ toDeleteList=( )
2121

2222

2323
generatedResources=("beam-loadtests-go-*-flink" "beam-loadtests-python-*-flink" \
24-
"beam-loadtests-py-*-flink" "beam-postcommit-python-chicago" )
24+
"beam-loadtests-py-*-flink" "beam-postcommit-python-chicago" \
25+
"beam-precommit-flink-container" )
2526

2627
function deleteFilteredClusters(){
2728
for cluster in ${toDeleteList[@]};do

.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ for image_name in ${IMAGE_NAMES[@]}; do
9696
# they will have a virtual size of 0 and a created date at the start of the epoch, but their manifests will
9797
# point to active images. These images should only be deleted when all of their dependencies can be safely
9898
# deleted.
99-
MANIFEST=$(docker manifest inspect ${image_name}@"${current}" || echo "")
99+
MANIFEST=$(docker buildx imagetools inspect ${image_name}@"${current}" --raw || echo "")
100100
if [ -z "$MANIFEST" ]; then
101101
# Sometimes "no such manifest" seen. Skip current if command hit error
102102
FAILED_IMAGES+=" $current"

0 commit comments

Comments
 (0)