Remove unnecessary checkNotNull (#34664)

akashorabek · web-flow · commit b2db7a41bd40 · 2025-04-18T10:05:08.000-04:00
diff --git a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarnessTest.java b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarnessTest.java
@@ -173,9 +173,8 @@ public void cleanUp() throws InterruptedException {
     Preconditions.checkNotNull(fanOutStreamingEngineWorkProvider).shutdown();
     stubFactory.shutdown();
     fakeStreamingEngineServer.shutdown();
-    if (!Preconditions.checkNotNull(
-        fakeStreamingEngineServer.awaitTermination(
-            SERVER_SHUTDOWN_TIMEOUT_SECONDS, TimeUnit.SECONDS))) {
+    if (!fakeStreamingEngineServer.awaitTermination(
+        SERVER_SHUTDOWN_TIMEOUT_SECONDS, TimeUnit.SECONDS)) {
       fakeStreamingEngineServer.shutdownNow();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -173,9 +173,8 @@ public void cleanUp() throws InterruptedException {`
`173`	`173`	`Preconditions.checkNotNull(fanOutStreamingEngineWorkProvider).shutdown();`
`174`	`174`	`stubFactory.shutdown();`
`175`	`175`	`fakeStreamingEngineServer.shutdown();`
`176`		`- if (!Preconditions.checkNotNull(`
`177`		`- fakeStreamingEngineServer.awaitTermination(`
`178`		`- SERVER_SHUTDOWN_TIMEOUT_SECONDS, TimeUnit.SECONDS))) {`
	`176`	`+ if (!fakeStreamingEngineServer.awaitTermination(`
	`177`	`+ SERVER_SHUTDOWN_TIMEOUT_SECONDS, TimeUnit.SECONDS)) {`
`179`	`178`	`fakeStreamingEngineServer.shutdownNow();`
`180`	`179`	`}`
`181`	`180`	`}`