Skip to content

Commit ab4a0f0

Browse files
MINOR: small optimization by judgment (#19386)
judgments can help avoid unnecessary `segments.sizeInBytes()` loops from https://github.com/apache/kafka/pull/18393/files#r2029925512 Reviewers: PoAn Yang <[email protected]>, Chia-Ping Tsai <[email protected]>
1 parent 74acbd2 commit ab4a0f0

File tree

1 file changed

+4
-3
lines changed
  • storage/src/main/java/org/apache/kafka/storage/internals/log

1 file changed

+4
-3
lines changed

Diff for: storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -467,9 +467,10 @@ public FetchDataInfo read(long startOffset,
467467
return maybeHandleIOException(
468468
() -> "Exception while reading from " + topicPartition + " in dir " + dir.getParent(),
469469
() -> {
470-
logger.trace("Reading maximum {} bytes at offset {} from log with total length {} bytes",
471-
maxLength, startOffset, segments.sizeInBytes());
472-
470+
if (logger.isTraceEnabled()) {
471+
logger.trace("Reading maximum {} bytes at offset {} from log with total length {} bytes",
472+
maxLength, startOffset, segments.sizeInBytes());
473+
}
473474
LogOffsetMetadata endOffsetMetadata = nextOffsetMetadata;
474475
long endOffset = endOffsetMetadata.messageOffset;
475476
Optional<LogSegment> segmentOpt = segments.floorSegment(startOffset);

0 commit comments

Comments
 (0)