MINOR: Remove unused ApiKeys.minRequiredInterBrokerMagic (#19325)

Reviewers: David Jacot <[email protected]>, Chia-Ping Tsai <[email protected]>

Author: ijuma

Diff for: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java

@@ -20,7 +20,6 @@
 import org.apache.kafka.common.message.ApiVersionsResponseData;
 import org.apache.kafka.common.protocol.types.Schema;
 import org.apache.kafka.common.protocol.types.Type;
-import org.apache.kafka.common.record.RecordBatch;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -67,11 +66,11 @@ public enum ApiKeys {
     DELETE_RECORDS(ApiMessageType.DELETE_RECORDS),
     INIT_PRODUCER_ID(ApiMessageType.INIT_PRODUCER_ID),
     OFFSET_FOR_LEADER_EPOCH(ApiMessageType.OFFSET_FOR_LEADER_EPOCH),
-    ADD_PARTITIONS_TO_TXN(ApiMessageType.ADD_PARTITIONS_TO_TXN, false, RecordBatch.MAGIC_VALUE_V2, false),
-    ADD_OFFSETS_TO_TXN(ApiMessageType.ADD_OFFSETS_TO_TXN, false, RecordBatch.MAGIC_VALUE_V2, false),
-    END_TXN(ApiMessageType.END_TXN, false, RecordBatch.MAGIC_VALUE_V2, false),
-    WRITE_TXN_MARKERS(ApiMessageType.WRITE_TXN_MARKERS, true, RecordBatch.MAGIC_VALUE_V2, false),
-    TXN_OFFSET_COMMIT(ApiMessageType.TXN_OFFSET_COMMIT, false, RecordBatch.MAGIC_VALUE_V2, false),
+    ADD_PARTITIONS_TO_TXN(ApiMessageType.ADD_PARTITIONS_TO_TXN, false, false),
+    ADD_OFFSETS_TO_TXN(ApiMessageType.ADD_OFFSETS_TO_TXN, false, false),
+    END_TXN(ApiMessageType.END_TXN, false, false),
+    WRITE_TXN_MARKERS(ApiMessageType.WRITE_TXN_MARKERS, true, false),
+    TXN_OFFSET_COMMIT(ApiMessageType.TXN_OFFSET_COMMIT, false, false),
     DESCRIBE_ACLS(ApiMessageType.DESCRIBE_ACLS),
     CREATE_ACLS(ApiMessageType.CREATE_ACLS, false, true),
     DELETE_ACLS(ApiMessageType.DELETE_ACLS, false, true),
@@ -95,19 +94,19 @@ public enum ApiKeys {
     ALTER_CLIENT_QUOTAS(ApiMessageType.ALTER_CLIENT_QUOTAS, false, true),
     DESCRIBE_USER_SCRAM_CREDENTIALS(ApiMessageType.DESCRIBE_USER_SCRAM_CREDENTIALS),
     ALTER_USER_SCRAM_CREDENTIALS(ApiMessageType.ALTER_USER_SCRAM_CREDENTIALS, false, true),
-    VOTE(ApiMessageType.VOTE, true, RecordBatch.MAGIC_VALUE_V0, false),
-    BEGIN_QUORUM_EPOCH(ApiMessageType.BEGIN_QUORUM_EPOCH, true, RecordBatch.MAGIC_VALUE_V0, false),
-    END_QUORUM_EPOCH(ApiMessageType.END_QUORUM_EPOCH, true, RecordBatch.MAGIC_VALUE_V0, false),
-    DESCRIBE_QUORUM(ApiMessageType.DESCRIBE_QUORUM, true, RecordBatch.MAGIC_VALUE_V0, true),
+    VOTE(ApiMessageType.VOTE, true, false),
+    BEGIN_QUORUM_EPOCH(ApiMessageType.BEGIN_QUORUM_EPOCH, true, false),
+    END_QUORUM_EPOCH(ApiMessageType.END_QUORUM_EPOCH, true, false),
+    DESCRIBE_QUORUM(ApiMessageType.DESCRIBE_QUORUM, true, true),
     ALTER_PARTITION(ApiMessageType.ALTER_PARTITION, true),
     UPDATE_FEATURES(ApiMessageType.UPDATE_FEATURES, true, true),
-    ENVELOPE(ApiMessageType.ENVELOPE, true, RecordBatch.MAGIC_VALUE_V0, false),
-    FETCH_SNAPSHOT(ApiMessageType.FETCH_SNAPSHOT, false, RecordBatch.MAGIC_VALUE_V0, false),
+    ENVELOPE(ApiMessageType.ENVELOPE, true, false),
+    FETCH_SNAPSHOT(ApiMessageType.FETCH_SNAPSHOT, false, false),
     DESCRIBE_CLUSTER(ApiMessageType.DESCRIBE_CLUSTER),
     DESCRIBE_PRODUCERS(ApiMessageType.DESCRIBE_PRODUCERS),
-    BROKER_REGISTRATION(ApiMessageType.BROKER_REGISTRATION, true, RecordBatch.MAGIC_VALUE_V0, false),
-    BROKER_HEARTBEAT(ApiMessageType.BROKER_HEARTBEAT, true, RecordBatch.MAGIC_VALUE_V0, false),
-    UNREGISTER_BROKER(ApiMessageType.UNREGISTER_BROKER, false, RecordBatch.MAGIC_VALUE_V0, true),
+    BROKER_REGISTRATION(ApiMessageType.BROKER_REGISTRATION, true, false),
+    BROKER_HEARTBEAT(ApiMessageType.BROKER_HEARTBEAT, true, false),
+    UNREGISTER_BROKER(ApiMessageType.UNREGISTER_BROKER, false, true),
     DESCRIBE_TRANSACTIONS(ApiMessageType.DESCRIBE_TRANSACTIONS),
     LIST_TRANSACTIONS(ApiMessageType.LIST_TRANSACTIONS),
     ALLOCATE_PRODUCER_IDS(ApiMessageType.ALLOCATE_PRODUCER_IDS, true, true),
@@ -123,8 +122,8 @@ public enum ApiKeys {
     SHARE_GROUP_DESCRIBE(ApiMessageType.SHARE_GROUP_DESCRIBE),
     SHARE_FETCH(ApiMessageType.SHARE_FETCH),
     SHARE_ACKNOWLEDGE(ApiMessageType.SHARE_ACKNOWLEDGE),
-    ADD_RAFT_VOTER(ApiMessageType.ADD_RAFT_VOTER, false, RecordBatch.MAGIC_VALUE_V0, true),
-    REMOVE_RAFT_VOTER(ApiMessageType.REMOVE_RAFT_VOTER, false, RecordBatch.MAGIC_VALUE_V0, true),
+    ADD_RAFT_VOTER(ApiMessageType.ADD_RAFT_VOTER, false, true),
+    REMOVE_RAFT_VOTER(ApiMessageType.REMOVE_RAFT_VOTER, false, true),
     UPDATE_RAFT_VOTER(ApiMessageType.UPDATE_RAFT_VOTER),
     INITIALIZE_SHARE_GROUP_STATE(ApiMessageType.INITIALIZE_SHARE_GROUP_STATE, true),
     READ_SHARE_GROUP_STATE(ApiMessageType.READ_SHARE_GROUP_STATE, true),
@@ -165,9 +164,6 @@ public enum ApiKeys {
     /** indicates if this is a ClusterAction request used only by brokers */
     public final boolean clusterAction;
 
-    /** indicates the minimum required inter broker magic required to support the API */
-    public final byte minRequiredInterBrokerMagic;
-
     /** indicates whether the API is enabled for forwarding */
     public final boolean forwardable;
 
@@ -180,24 +176,18 @@ public enum ApiKeys {
     }
 
     ApiKeys(ApiMessageType messageType, boolean clusterAction) {
-        this(messageType, clusterAction, RecordBatch.MAGIC_VALUE_V0, false);
-    }
-
-    ApiKeys(ApiMessageType messageType, boolean clusterAction, boolean forwardable) {
-        this(messageType, clusterAction, RecordBatch.MAGIC_VALUE_V0, forwardable);
+        this(messageType, clusterAction, false);
     }
 
     ApiKeys(
         ApiMessageType messageType,
         boolean clusterAction,
-        byte minRequiredInterBrokerMagic,
         boolean forwardable
     ) {
         this.messageType = messageType;
         this.id = messageType.apiKey();
         this.name = messageType.name;
         this.clusterAction = clusterAction;
-        this.minRequiredInterBrokerMagic = minRequiredInterBrokerMagic;
         this.requiresDelayedAllocation = forwardable || shouldRetainsBufferReference(messageType.requestSchemas());
         this.forwardable = forwardable;
     }