Skip to content

Commit e2d472d

Browse files
MINOR: Minor tidying in GroupMetadataManager (#19411)
Some trivial tidying up in GroupMetadataManager. Reviewers: Lianet Magrans <[email protected]>
1 parent fcf6da0 commit e2d472d

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java

+4-5
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ StreamsGroup getOrCreateStreamsGroup(
866866
* @param groupId The group ID.
867867
*
868868
* @return A StreamsGroup.
869-
* @throws GroupIdNotFoundException if the group does not exist
869+
* @throws GroupIdNotFoundException if the group does not exist or is not a streams group.
870870
*
871871
* Package private for testing.
872872
*/
@@ -1172,8 +1172,8 @@ ShareGroup getOrMaybeCreatePersistedShareGroup(
11721172
* @param groupId The group id.
11731173
* @param committedOffset A specified committed offset corresponding to this shard.
11741174
*
1175-
* @return A ConsumerGroup.
1176-
* @throws GroupIdNotFoundException if the group does not exist or is not a consumer group.
1175+
* @return A ShareGroup.
1176+
* @throws GroupIdNotFoundException if the group does not exist or is not a share group.
11771177
*/
11781178
public ShareGroup shareGroup(
11791179
String groupId,
@@ -1588,7 +1588,7 @@ private static void throwIfStreamsGroupHeartbeatRequestIsInvalid(
15881588
}
15891589
} else if (request.memberEpoch() == LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
15901590
throwIfNull(request.instanceId(), "InstanceId can't be null.");
1591-
} else if (request.memberEpoch() < LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
1591+
} else if (request.memberEpoch() < LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
15921592
throw new InvalidRequestException(String.format("MemberEpoch is %d, but must be greater than or equal to -2.",
15931593
request.memberEpoch()));
15941594
}
@@ -3418,7 +3418,6 @@ private static void filterTopicDescribeAuthorizedTopics(
34183418
resolvedRegexes.forEach((__, topicNames) -> topicNames.removeAll(deniedTopics));
34193419
}
34203420

3421-
34223421
/**
34233422
* Handle the result of the asynchronous tasks which resolves the regular expressions.
34243423
*

0 commit comments

Comments
 (0)