Skip to content

Commit 6635114

Browse files
committed
[MPLUGIN-501] Upgrade to Doxia 2.0.0 Milestone Stack
This closes #297
1 parent 1520654 commit 6635114

File tree

11 files changed

+19
-43
lines changed

11 files changed

+19
-43
lines changed

maven-plugin-report-plugin/pom.xml

+4-5
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
<properties>
4141
<it.debug>true</it.debug>
42-
<doxiaVersion>1.11.1</doxiaVersion>
42+
<doxiaVersion>2.0.0-M12</doxiaVersion>
4343
</properties>
4444

4545
<dependencies>
@@ -120,8 +120,7 @@
120120
<dependency>
121121
<groupId>org.apache.commons</groupId>
122122
<artifactId>commons-lang3</artifactId>
123-
<version>3.8.1</version>
124-
<!--same version as used by doxia site renderer -->
123+
<version>3.16.0</version>
125124
</dependency>
126125
<!-- Plexus -->
127126
<dependency>
@@ -271,8 +270,8 @@
271270
<settingsFile>src/it/settings.xml</settingsFile>
272271
<streamLogsOnFailures>true</streamLogsOnFailures>
273272
<filterProperties>
274-
<sitePluginVersion>3.12.1</sitePluginVersion>
275-
<projectInfoReportsPlugin>3.4.1</projectInfoReportsPlugin>
273+
<sitePluginVersion>3.20.0</sitePluginVersion>
274+
<projectInfoReportsPlugin>3.7.0</projectInfoReportsPlugin>
276275
<antVersion>${antVersion}</antVersion>
277276
</filterProperties>
278277
<properties>

maven-plugin-report-plugin/src/it/plugin-report-annotations/src/main/java/org/DummyReport.java

-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ protected MavenProject getProject() {
108108
*/
109109
public boolean canGenerateReport() {
110110
if (skip || skipReport) {
111-
getLog().info("Maven Plugin Plugin Report generation skipped.");
112111
return false;
113112
}
114113

maven-plugin-report-plugin/src/it/plugin-report-with-javadoc-links/pom.xml

-3
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,6 @@ under the License.
101101
<groupId>org.apache.maven.plugins</groupId>
102102
<artifactId>maven-site-plugin</artifactId>
103103
<version>@sitePluginVersion@</version>
104-
<configuration>
105-
<locales>en</locales>
106-
</configuration>
107104
</plugin>
108105
</plugins>
109106
</build>

maven-plugin-report-plugin/src/it/plugin-report/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ under the License.
9494
<artifactId>maven-site-plugin</artifactId>
9595
<version>@sitePluginVersion@</version>
9696
<configuration>
97-
<locales>en,de,fr</locales>
97+
<locales>default,de,fr</locales>
9898
</configuration>
9999
</plugin>
100100
</plugins>

maven-plugin-report-plugin/src/it/plugin-report/src/main/java/org/DummyReport.java

-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ protected MavenProject getProject() {
102102
/** {@inheritDoc} */
103103
public boolean canGenerateReport() {
104104
if (skip || skipReport) {
105-
getLog().info("Maven Plugin Plugin Report generation skipped.");
106105
return false;
107106
}
108107

maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/GoalRenderer.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import org.apache.commons.lang3.StringUtils;
3838
import org.apache.maven.doxia.sink.Sink;
3939
import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet.Semantics;
40-
import org.apache.maven.doxia.util.HtmlTools;
40+
import org.apache.maven.doxia.util.DoxiaUtils;
4141
import org.apache.maven.plugin.descriptor.MojoDescriptor;
4242
import org.apache.maven.plugin.descriptor.Parameter;
4343
import org.apache.maven.plugin.logging.Log;
@@ -260,7 +260,7 @@ private void renderParameterOverviewTableRow(Parameter parameter) {
260260
renderTableCellWithCode(
261261
format("parameter.name", parameter.getName()),
262262
// no need for additional URI encoding as it returns only URI safe characters
263-
Optional.of("#" + HtmlTools.encodeId(parameter.getName())));
263+
Optional.of("#" + DoxiaUtils.encodeId(parameter.getName())));
264264

265265
// type
266266
Map.Entry<String, Optional<String>> type = getLinkedType(parameter, true);

maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ private void renderUsageSection(boolean hasMavenReport) {
326326
sb.append(" ...").append(Markup.EOL);
327327
sb.append("</project>");
328328

329-
verbatimText(sb.toString());
329+
verbatimSource(sb.toString());
330330

331331
sink.paragraph();
332332
linkPatternedText(getI18nString("configuration.end"));

maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java

-2
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ public class PluginReport extends AbstractMavenReport {
163163
@Override
164164
public boolean canGenerateReport() {
165165
if (skip) {
166-
getLog().info("Maven Plugin Plugin Report generation skipped.");
167166
return false;
168167
}
169168

@@ -273,7 +272,6 @@ public String getOutputName() {
273272
*/
274273
private void generateMojosDocumentation(PluginDescriptor pluginDescriptor, Locale locale)
275274
throws MavenReportException {
276-
277275
if (pluginDescriptor.getMojos() != null) {
278276
for (MojoDescriptor descriptor : pluginDescriptor.getMojos()) {
279277
GoalRenderer renderer;

maven-plugin-tools-generators/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
<!-- other -->
8282
<dependency>
8383
<groupId>org.apache.velocity</groupId>
84-
<artifactId>velocity</artifactId>
84+
<artifactId>velocity-engine-core</artifactId>
8585
</dependency>
8686
<dependency>
8787
<groupId>org.slf4j</groupId>

maven-plugin-tools-generators/src/test/resources/expected-testGoal-mojo.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
</li>
4848
</ul>
4949
<subsection name="Required Parameters">
50-
<table border="0" class="bodyTable">
50+
<table class="bodyTable">
5151
<tr>
5252
<th>Name</th>
5353
<th>Type</th>
@@ -81,7 +81,7 @@
8181
</table>
8282
</subsection>
8383
<subsection name="Optional Parameters">
84-
<table border="0" class="bodyTable">
84+
<table class="bodyTable">
8585
<tr>
8686
<th>Name</th>
8787
<th>Type</th>
@@ -109,7 +109,7 @@
109109
<subsection name="Parameter Details">
110110
<h4>
111111
<strong>
112-
<a name="dir">&lt;dir&gt;</a>
112+
<a id="dir">&lt;dir&gt;</a>
113113
</strong>
114114
</h4>
115115
<div>Test parameter description</div>
@@ -142,7 +142,7 @@
142142
<hr/>
143143
<h4>
144144
<strong>
145-
<a name="withoutSince">&lt;withoutSince&gt;</a>
145+
<a id="withoutSince">&lt;withoutSince&gt;</a>
146146
</strong>
147147
</h4>
148148
<div>(no description)</div>

pom.xml

+6-22
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,10 @@
104104
<asmVersion>9.7</asmVersion>
105105
<plexusUtilsVersion>4.0.1</plexusUtilsVersion>
106106
<plexusXmlVersion>3.0.1</plexusXmlVersion>
107-
<reportingApiVersion>3.1.1</reportingApiVersion>
108-
<reportingImplVersion>3.2.0</reportingImplVersion>
107+
<reportingApiVersion>4.0.0-M12</reportingApiVersion>
108+
<reportingImplVersion>4.0.0-M15</reportingImplVersion>
109109
<compilerPluginVersion>3.11.0</compilerPluginVersion>
110-
<javadocPluginVersion>3.5.0</javadocPluginVersion>
110+
<javadocPluginVersion>3.8.0</javadocPluginVersion>
111111
<enforcerPluginVersion>3.5.0</enforcerPluginVersion>
112112
<project.build.outputTimestamp>2024-08-14T15:41:34Z</project.build.outputTimestamp>
113113
</properties>
@@ -200,12 +200,6 @@
200200
<groupId>org.apache.maven.reporting</groupId>
201201
<artifactId>maven-reporting-impl</artifactId>
202202
<version>${reportingImplVersion}</version>
203-
<exclusions>
204-
<exclusion>
205-
<groupId>org.codehaus.plexus</groupId>
206-
<artifactId>plexus-container-default</artifactId>
207-
</exclusion>
208-
</exclusions>
209203
</dependency>
210204

211205
<dependency>
@@ -237,24 +231,14 @@
237231
<dependency>
238232
<groupId>org.codehaus.plexus</groupId>
239233
<artifactId>plexus-velocity</artifactId>
240-
<version>1.2</version>
241-
<exclusions>
242-
<exclusion>
243-
<groupId>org.codehaus.plexus</groupId>
244-
<artifactId>plexus-container-default</artifactId>
245-
</exclusion>
246-
<exclusion>
247-
<groupId>velocity</groupId>
248-
<artifactId>velocity</artifactId>
249-
</exclusion>
250-
</exclusions>
234+
<version>2.1.0</version>
251235
</dependency>
252236

253237
<!-- other -->
254238
<dependency>
255239
<groupId>org.apache.velocity</groupId>
256-
<artifactId>velocity</artifactId>
257-
<version>1.7</version>
240+
<artifactId>velocity-engine-core</artifactId>
241+
<version>2.3</version>
258242
</dependency>
259243

260244
<dependency>

0 commit comments

Comments
 (0)