Skip to content

Commit bec4cce

Browse files
committed
Used underscore function names. Added manual type casting.
1 parent 3e2f6aa commit bec4cce

File tree

2 files changed

+12
-15
lines changed

2 files changed

+12
-15
lines changed

pulsar/__init__.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1451,32 +1451,32 @@ def __init__(
14511451
raise ValueError("When using key_shared_mode = KeySharedMode.Sticky you must also provide sticky_ranges")
14521452

14531453
self._policy = KeySharedPolicy()
1454-
self._policy.setKeySharedMode(key_shared_mode)
1455-
self._policy.setAllowOutOfOrderDelivery(allow_out_of_order_delivery)
1454+
self._policy.set_key_shared_mode(key_shared_mode)
1455+
self._policy.set_allow_out_of_order_delivery(allow_out_of_order_delivery)
14561456

14571457
if sticky_ranges is not None:
1458-
self._policy.setStickyRanges(sticky_ranges)
1458+
self._policy.set_sticky_ranges(sticky_ranges)
14591459

14601460
@property
14611461
def key_shared_mode(self) -> KeySharedMode:
14621462
"""
14631463
Returns the key shared mode
14641464
"""
1465-
return self._policy.getKeySharedMode()
1465+
return self._policy.get_key_shared_mode()
14661466

14671467
@property
14681468
def allow_out_of_order_delivery(self) -> bool:
14691469
"""
14701470
Returns whether out of order delivery is enabled
14711471
"""
1472-
return self._policy.isAllowOutOfOrderDelivery()
1472+
return self._policy.is_allow_out_of_order_delivery()
14731473

14741474
@property
14751475
def sticky_ranges(self) -> List[Tuple[int, int]]:
14761476
"""
14771477
Returns the actual sticky ranges
14781478
"""
1479-
return self._policy.getStickyRanges()
1479+
return self._policy.get_sticky_ranges()
14801480

14811481
def policy(self):
14821482
"""

src/config.cc

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,20 +120,17 @@ static ClientConfiguration& ClientConfiguration_setFileLogger(ClientConfiguratio
120120
return conf;
121121
}
122122

123-
template <typename... Args>
124-
using overload_cast_ = pybind11::detail::overload_cast_impl<Args...>;
125-
126123
void export_config(py::module_& m) {
127124
using namespace py;
128125

129126
class_<KeySharedPolicy, std::shared_ptr<KeySharedPolicy>>(m, "KeySharedPolicy")
130127
.def(init<>())
131-
.def("setKeySharedMode", &KeySharedPolicy::setKeySharedMode, return_value_policy::reference)
132-
.def("getKeySharedMode", &KeySharedPolicy::getKeySharedMode)
133-
.def("setAllowOutOfOrderDelivery", &KeySharedPolicy::setAllowOutOfOrderDelivery, return_value_policy::reference)
134-
.def("isAllowOutOfOrderDelivery", &KeySharedPolicy::isAllowOutOfOrderDelivery)
135-
.def("setStickyRanges", overload_cast_<StickyRanges>()(&KeySharedPolicy::setStickyRanges), return_value_policy::reference)
136-
.def("getStickyRanges", &KeySharedPolicy::getStickyRanges);
128+
.def("set_key_shared_mode", &KeySharedPolicy::setKeySharedMode, return_value_policy::reference)
129+
.def("get_key_shared_mode", &KeySharedPolicy::getKeySharedMode)
130+
.def("set_allow_out_of_order_delivery", &KeySharedPolicy::setAllowOutOfOrderDelivery, return_value_policy::reference)
131+
.def("is_allow_out_of_order_delivery", &KeySharedPolicy::isAllowOutOfOrderDelivery)
132+
.def("set_sticky_ranges", static_cast<KeySharedPolicy& (KeySharedPolicy::*)(const StickyRanges&)>(&KeySharedPolicy::setStickyRanges), return_value_policy::reference)
133+
.def("get_sticky_ranges", &KeySharedPolicy::getStickyRanges);
137134

138135
class_<CryptoKeyReader, std::shared_ptr<CryptoKeyReader>>(m, "AbstractCryptoKeyReader")
139136
.def("getPublicKey", &CryptoKeyReader::getPublicKey)

0 commit comments

Comments
 (0)