fix update user not valid bug (#8926)

dingshuangxi888 · web-flow · commit 797024f3f8cb · 2024-11-15T10:35:37.000+08:00
diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
@@ -3113,7 +3113,7 @@ private RemotingCommand updateUser(ChannelHandlerContext ctx,
                 if (old.getUserType() == UserType.SUPER && isNotSuperUserLogin(request)) {
                     throw new AuthenticationException("The super user can only be update by super user");
                 }
-                return this.brokerController.getAuthenticationMetadataManager().updateUser(old);
+                return this.brokerController.getAuthenticationMetadataManager().updateUser(user);
             }).thenAccept(nil -> response.setCode(ResponseCode.SUCCESS))
             .exceptionally(ex -> {
                 LOGGER.error("update user {} error", requestHeader.getUsername(), ex);

Original file line number	Diff line number	Diff line change
`@@ -3113,7 +3113,7 @@ private RemotingCommand updateUser(ChannelHandlerContext ctx,`
`3113`	`3113`	`if (old.getUserType() == UserType.SUPER && isNotSuperUserLogin(request)) {`
`3114`	`3114`	`throw new AuthenticationException("The super user can only be update by super user");`
`3115`	`3115`	`}`
`3116`		`- return this.brokerController.getAuthenticationMetadataManager().updateUser(old);`
	`3116`	`+ return this.brokerController.getAuthenticationMetadataManager().updateUser(user);`
`3117`	`3117`	`}).thenAccept(nil -> response.setCode(ResponseCode.SUCCESS))`
`3118`	`3118`	`.exceptionally(ex -> {`
`3119`	`3119`	`LOGGER.error("update user {} error", requestHeader.getUsername(), ex);`