Skip to content

Commit 3f2f414

Browse files
glasserabernix
andauthored
chore(deps): specify versions for @types/express and friends (#4493)
* chore(deps): specify versions for `@types/express` and friends In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me. * Remove a couple type dependencies from `apollo-server-express`. - We don't directly depend on `@types/express-serve-static-core`, so I don't quite understand the addition of those. I seem to not have the flapping of deps without adding it! - We shouldn't need to package the `@types/qs` (or the aforementioned pkg) into the `apollo-server-express` package's non-dev deps because none of those types are exported from our emitted `d.ts` files. Those dependencies should be brought by the corresponding packages if there are transitive dep needs. Co-authored-by: Jesse Rosenberger <[email protected]>
1 parent ebbc239 commit 3f2f414

File tree

3 files changed

+38
-17
lines changed

3 files changed

+38
-17
lines changed

package-lock.json

+34-16
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@
6666
"@types/body-parser": "1.19.0",
6767
"@types/bunyan": "1.8.6",
6868
"@types/connect": "3.4.33",
69+
"@types/cors": "2.8.7",
70+
"@types/express": "4.17.7",
6971
"@types/fast-json-stable-stringify": "2.0.0",
7072
"@types/hapi": "17.8.8",
7173
"@types/ioredis": "4.17.2",
@@ -81,6 +83,7 @@
8183
"@types/nock": "10.0.3",
8284
"@types/node": "8.10.62",
8385
"@types/node-fetch": "2.3.2",
86+
"@types/qs": "6.9.4",
8487
"@types/qs-middleware": "1.0.1",
8588
"@types/request": "2.48.5",
8689
"@types/request-promise": "4.1.46",

packages/apollo-server-express/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"@apollographql/graphql-playground-html": "1.6.26",
3131
"@types/accepts": "^1.3.5",
3232
"@types/body-parser": "1.19.0",
33-
"@types/cors": "^2.8.4",
33+
"@types/cors": "2.8.7",
3434
"@types/express": "4.17.7",
3535
"accepts": "^1.3.5",
3636
"apollo-server-core": "file:../apollo-server-core",

0 commit comments

Comments
 (0)