Skip to content

[1.20.1] Forge Access Transformer fails to remap vanilla methods overridden from a super class #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fuzss opened this issue Mar 8, 2025 · 0 comments

Comments

@Fuzss
Copy link

Fuzss commented Mar 8, 2025

Java: 21.0.3 JVM: 21.0.3+9-LTS(Amazon.com Inc.) Arch: aarch64
Architect Plugin: 3.4.161
Architectury Loom: 1.9.428
Minecraft Forge: 47.4.0

Access Widener file in Common subproject:

accessible  method  net/minecraft/world/entity/decoration/ItemFrame setDirection    (Lnet/minecraft/core/Direction;)V
accessible  method  net/minecraft/world/entity/decoration/HangingEntity setDirection    (Lnet/minecraft/core/Direction;)V

Access Transformer file in Forge production jar:

public net.minecraft.world.entity.decoration.HangingEntity m_6022_(Lnet/minecraft/core/Direction;)V
public net.minecraft.world.entity.decoration.ItemFrame setDirection(Lnet/minecraft/core/Direction;)V

Also checked the Access Widener file in the Fabric production jar and that has remapped correctly.
This happens every time, so not just some concurrency issue.

The issue can also be observed with AbstractSkeleton::getStepSound where only the method in AbstractSkeleton is successfully remapped for the Forge Access Transformer in the production jar.

transitive-extendable   method  net/minecraft/world/entity/monster/AbstractSkeleton getStepSound    ()Lnet/minecraft/sounds/SoundEvent;
transitive-extendable   method  net/minecraft/world/entity/monster/Skeleton getStepSound    ()Lnet/minecraft/sounds/SoundEvent;
transitive-extendable   method  net/minecraft/world/entity/monster/Stray    getStepSound    ()Lnet/minecraft/sounds/SoundEvent;
transitive-extendable   method  net/minecraft/world/entity/monster/WitherSkeleton   getStepSound    ()Lnet/minecraft/sounds/SoundEvent;

Here is the repository this was tested with: https://github.com/Fuzss/fastitemframes/blob/main/1.20.1/Common/src/main/resources/fastitemframes.accesswidener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant