Skip to content

Add the ability to exclude files when using the git file generator #468 #13690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christianh814 opened this issue May 22, 2023 · 8 comments · May be fixed by #22734
Open

Add the ability to exclude files when using the git file generator #468 #13690

christianh814 opened this issue May 22, 2023 · 8 comments · May be fixed by #22734
Assignees
@nitishfy
Labels
enhancement New feature or request

Comments

@christianh814
Copy link
Member

NOTE: Original Issue found here

When using the git directory generator it is possible to exclude specific paths like this

  - git:
      repoURL: https://github.com/argoproj-labs/applicationset.git
      revision: HEAD
      directories:
      - path: examples/git-generator-directory/excludes/cluster-addons/*
      - path: examples/git-generator-directory/excludes/cluster-addons/exclude-helm-guestbook
        exclude: true

When using the git file generator I would like to be able to add files using a wildcard and then exclude specific files like this

spec:
  generators:
  - git:
      repoURL: https://github.com/argoproj-labs/applicationset.git
      revision: HEAD
      files:
      - path: "examples/git-generator-files-discovery/cluster-config/**/config.json"
      - path  "examples/git-generator-files-discovery/cluster-config/staging/config.json"
        exclude: true

Of course if there is another way to do this that I am not aware of then I would be happy to use that. If not I am also happy to implement this change if it is agreed.
@christianh814 christianh814 added the enhancement New feature or request label May 22, 2023
@christianh814 christianh814 mentioned this issue May 22, 2023
Closed
@MattiDeGrauwe
Copy link

@christianh814 did you find a workaround for this? also in need for this feature

@krisdock
Copy link

we have a pressing need for this as well. thanks for working on it.

@vl-kp
Copy link

vl-kp commented Aug 30, 2023 •
edited
Loading

any workaround?

looks like there is a PR for this at here argoproj/applicationset#468
but not migrated yet

@hubmat00
Copy link

anyone knows if the proposed PR from old applicationset repo got ever moved to argoproj/argo-cd?

if not, would you mind if I take over this issue and move/migrate this proposed PR by @adamjohnson01 ?!

FYI @crenshaw-dev @adamjohnson01 as you were mainly involved in the original issue.

hubmat00 added a commit to hubmat00/argo-cd that referenced this issue Oct 14, 2023
@hubmat00
feat: add the ability to exclude files when using the git file genera…
a726535 
…tor (argoproj#13690)
hubmat00 added a commit to hubmat00/argo-cd that referenced this issue Oct 14, 2023
@hubmat00
feat: filtering logic for exluded paths (git file generator) must sta…
fd4263a 
…y backwards-compatible with the default greedy git file generator gloobing (argoproj#13690)
This was referenced Oct 16, 2023
Closed
Closed
hubmat00 added a commit to hubmat00/argo-cd that referenced this issue Oct 16, 2023
@hubmat00
feat: add the ability to exclude files when using the git file genera…
6794ea1 
…tor (argoproj#13690)

Signed-off-by: hubmat00 <[email protected]>
hubmat00 added a commit to hubmat00/argo-cd that referenced this issue Oct 16, 2023
@hubmat00
feat: filtering logic for exluded paths (git file generator) must sta…
d637488 
…y backwards-compatible with the default greedy git file generator gloobing (argoproj#13690)

Signed-off-by: hubmat00 <[email protected]>
hubmat00 added a commit to hubmat00/argo-cd that referenced this issue Oct 20, 2023
@hubmat00
feat: add the ability to exclude files when using the git file genera…
f2b66f9 
…tor (argoproj#13690)

Signed-off-by: hubmat00 <[email protected]>
@pachecoc
Copy link

@vl-kp perhaps the workaround now is to create another appset that points to a different file than the first appset.

Current appset points to .../config.json
New appset will point to something like .../config-staging.json

@denzhel
Copy link

denzhel commented Apr 9, 2025

Any update on this ? This would be very helpful

@vietwow
Copy link

vietwow commented Apr 10, 2025

Any update on this ? Thanks

@nitishfy
Copy link
Member

nitishfy commented Apr 21, 2025 •
edited
Loading

I'm working on this, will be raising a PR shortly.

@nitishfy nitishfy linked a pull request Apr 21, 2025 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitishfy nitishfy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
9 participants
@krisdock @christianh814 @vietwow @MattiDeGrauwe @pachecoc @denzhel @hubmat00 @nitishfy @vl-kp