Skip to content

fix: More thorough search through search.filters w/ workspaces #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

merc1031
Copy link

@merc1031 merc1031 commented Apr 16, 2025

Do not just pick first from search.filters, consider all options, filtering based on git-root and workspaces config

Fix: #2700
Might Fix: #2536

Wrote a few simple unit tests, and tried it by running the client locally. Not sure about which of "[search] filters" vs "workspaces" should be more respected, so i made it so if workspaces = false, regardless of whats in "[search] filters" workspace gets filtered out.

First time looking at atuins code, let me know if this needs any changes.

edit: (from my post here: #2536 (comment))

workspaces = true
[search]
filters = [ "workspace", "directory", "session", "global" ]
^R for the ... time in a git repo any other dir
first workspace directory
second directory session
third session global
fourth global directory
fifth workspace session
sixth directory global

Image

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Do not just pick first from search.filters, consider all options,
filtering based on git-root and workspaces config

atuinsh#2700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant