Definitive fix for #452 using an updated fast-adapter

Author: RobbWatershed

app/build.gradle

@@ -175,12 +175,12 @@ dependencies {
     implementation 'com.jakewharton.threetenabp:threetenabp:1.2.1'
 
     // https://github.com/mikepenz/FastAdapter
-    implementation "com.mikepenz:fastadapter:4.1.2" // needs the `expandable`, `drag` and `scroll` extension.
-    implementation "com.mikepenz:fastadapter-extensions-drag:4.1.2" // drag support
-    implementation "com.mikepenz:fastadapter-extensions-expandable:4.1.2"
-    implementation "com.mikepenz:fastadapter-extensions-scroll:4.1.2" // scroll helpers
-    implementation "com.mikepenz:fastadapter-extensions-paged:4.1.2"
-    implementation "com.mikepenz:fastadapter-extensions-utils:4.1.2" // needs the `expandable`, `drag` and `scroll` extension.
+    implementation "com.mikepenz:fastadapter:5.0.0-a03" // needs the `expandable`, `drag` and `scroll` extension.
+    implementation "com.mikepenz:fastadapter-extensions-drag:5.0.0-a03" // drag support
+    implementation "com.mikepenz:fastadapter-extensions-expandable:5.0.0-a03"
+    implementation "com.mikepenz:fastadapter-extensions-scroll:5.0.0-a03" // scroll helpers
+    implementation "com.mikepenz:fastadapter-extensions-paged:5.0.0-a03"
+    implementation "com.mikepenz:fastadapter-extensions-utils:5.0.0-a03" // needs the `expandable`, `drag` and `scroll` extension.
     implementation "com.mikepenz:materialize:1.2.1"
 
     // ProgressDialog alternative - https://github.com/Livin21/MissMe

app/src/main/java/me/devsaki/hentoid/fragments/library/LibraryFragment.java

@@ -881,7 +881,6 @@ private void loadBookshelf(PagedList<Content> iLibrary) {
                 return;
             }
 
-            // TODO explore using PagedList.Callback instead
             /* We're using PagedList v2.1.1 against the use case it has been designed for (endless lists loaded linearly).
             Doing it right requires the following algorithm :
 
@@ -896,7 +895,6 @@ Check if there is unloaded data in the working dataset (iLibrary)
                 NB : Case C implementation  _is_ quick and hacky (no discussion about that).
                 The alternative would be to implement a whole alternate data source for Hentoid paged mode, which is massively more complex
              */
-
             //noinspection Convert2MethodRef need API24
             long nbPlaceholders = Stream.of(iLibrary.subList(minIndex, maxIndex)).filter(c -> c == null).count();
             Timber.d(">> nb placeholders : %s", nbPlaceholders);
@@ -996,6 +994,7 @@ private void onLibraryChanged(PagedList<Content> result) {
         if (Preferences.getEndlessScroll()) {
             pagedItemAdapter.submitList(result, this::differEndCallback);
         } else {
+
             if (newSearch) pager.setCurrentPage(1);
             pager.setPageCount((int) Math.ceil(result.size() * 1.0 / Preferences.getContentPageQuantity()));
             minLoadedBound = Integer.MAX_VALUE;
@@ -1039,8 +1038,7 @@ private void updateTitle(long totalSelectedCount, long totalCount) {
     private boolean onBookClick(ContentItem item, int position) {
         if (0 == selectExtension.getSelectedItems().size()) {
             if (!invalidateNextBookClick) {
-                topItemPosition = position;
-//                unObserveAll();
+                topItemPosition = position; // TODO - still useful ?
                 ContentHelper.openHentoidViewer(requireContext(), item.getContent(), viewModel.getSearchManagerBundle());
             } else invalidateNextBookClick = false;
 
@@ -1138,7 +1136,7 @@ private void differEndCallback() {
             Timber.i(">> differEnd::current vs. memorized %s / %s", currentPosition, topItemPosition);
             if (currentPosition != topItemPosition) {
                 Timber.i(">> differEnd::scrolling to last memorized position : %s", topItemPosition);
-//                llm.scrollToPositionWithOffset(topItemPosition, 0);
+//                llm.scrollToPositionWithOffset(topItemPosition, 0); // TODO - enable or delete the whole method
                 topItemPosition = -1;
             }
         }