Skip to content

Commit 4886a3e

Browse files
authored
fix(glue-alpha): inconsistent workflow addconditionalTrigger casing (#33752)
### Issue #33751 Closes #33751. ### Reason for this change The conditional workflow trigger (`addconditionalTrigger`) in the `aws-glue-alpha` package contains inconsistent casing and should be updated to camel case. ### Description of changes Updated the conditional workflow trigger (`addconditionalTrigger`) to camel case (`addConditionalTrigger`). ### Describe any new or updated permissions being added None. ### Description of how you validated changes Updated existing unit and integration tests, `aws-glue-alpha/test/integ.workflow.ts` and `aws-glue-alpha/test/workflow-triggers.test.ts`. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: Updated casing of `workflow.addconditionalTrigger` to `workflow.addConditionalTrigger`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 55a3c4c commit 4886a3e

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/@aws-cdk/aws-glue-alpha/lib/triggers/workflow.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ export abstract class WorkflowBase extends cdk.Resource implements IWorkflow {
248248
* @throws If a job is provided without a job state, or if a crawler is provided without a crawler state for any condition.
249249
* @returns The created CfnTrigger resource.
250250
*/
251-
public addconditionalTrigger(id: string, options: ConditionalTriggerOptions): CfnTrigger {
251+
public addConditionalTrigger(id: string, options: ConditionalTriggerOptions): CfnTrigger {
252252
const trigger = new CfnTrigger(this, id, {
253253
...options,
254254
workflowName: this.workflowName,

packages/@aws-cdk/aws-glue-alpha/test/integ.workflow.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ workflow.addOnDemandTrigger('OnDemandTrigger', {
3737
actions: [{ job: InboundJob }],
3838
});
3939

40-
workflow.addconditionalTrigger('ConditionalTrigger', {
40+
workflow.addConditionalTrigger('ConditionalTrigger', {
4141
actions: [{ job: OutboundJob }],
4242
predicate: {
4343
conditions: [

packages/@aws-cdk/aws-glue-alpha/test/workflow-triggers.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe('Workflow and Triggers', () => {
6464
});
6565

6666
test('creates a workflow with conditional trigger', () => {
67-
workflow.addconditionalTrigger('ConditionalTrigger', {
67+
workflow.addConditionalTrigger('ConditionalTrigger', {
6868
actions: [{ job }],
6969
predicate: {
7070
conditions: [

0 commit comments

Comments
 (0)