Skip to content

Missing methods within s3manageriface package #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JordanSussman opened this issue Dec 30, 2022 · 2 comments
Closed

Missing methods within s3manageriface package #4676

JordanSussman opened this issue Dec 30, 2022 · 2 comments
Assignees
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue

Comments

@JordanSussman
Copy link

Describe the bug

The s3manageriface package is missing numerous methods that exist within the s3manager package.

Expected Behavior

All methods that exist within s3manager are able to be mocked by utilizing the s3manageriface package.

Current Behavior

Unable to mock the NewDeleteListIterator within the s3manager package.

Reproduction Steps

Attempt to mock functions like NewDeleteListIterator within the s3manager package.

Possible Solution

No response

Additional Information/Context

No response

SDK version used

v1.44.170

Environment details (Version of Go (go version)? OS name and version, etc.)

go1.19.1 darwin/arm64

@JordanSussman JordanSussman added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 30, 2022
@JordanSussman JordanSussman changed the title (short issue description) Missing methods within s3manageriface package Dec 30, 2022
@RanVaknin RanVaknin self-assigned this Jan 4, 2023
@RanVaknin
Copy link
Contributor

Hi @JordanSussman,

This is one of few hand-written clients so the types are not auto-generated like the rest of our clients. I will change this to a feature request and add to the backlog.

Thanks,
Ran

@RanVaknin RanVaknin added feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2023
@lucix-aws lucix-aws closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

3 participants