Minor - Fixing to_text bucketing

Author: jaidisido

awswrangler/s3/_write_parquet.py

@@ -143,14 +143,14 @@ def _to_parquet(
     index: bool,
     compression: Optional[str],
     compression_ext: str,
-    filename_prefix: str,
     cpus: int,
     dtype: Dict[str, str],
     boto3_session: Optional[boto3.Session],
     s3_additional_kwargs: Optional[Dict[str, str]],
     use_threads: bool,
     path: Optional[str] = None,
     path_root: Optional[str] = None,
+    filename_prefix: Optional[str] = uuid.uuid4().hex,
     max_rows_by_file: Optional[int] = 0,
 ) -> List[str]:
     if path is None and path_root is not None:
@@ -538,7 +538,6 @@ def to_parquet(  # pylint: disable=too-many-arguments,too-many-locals
             df=df,
             path=path,
             schema=schema,
-            filename_prefix=filename_prefix,
             index=index,
             cpus=cpus,
             compression=compression,

awswrangler/s3/_write_text.py

@@ -37,13 +37,12 @@ def _to_text(
     s3_additional_kwargs: Optional[Dict[str, str]],
     path: Optional[str] = None,
     path_root: Optional[str] = None,
-    filename_prefix: Optional[str] = None,
+    filename_prefix: Optional[str] = uuid.uuid4().hex,
     **pandas_kwargs: Any,
 ) -> List[str]:
     if df.empty is True:
         raise exceptions.EmptyDataFrame()
     if path is None and path_root is not None:
-        filename_prefix = filename_prefix + uuid.uuid4().hex if filename_prefix else uuid.uuid4().hex
         file_path: str = (
             f"{path_root}{filename_prefix}.{file_format}{_COMPRESSION_2_EXT.get(pandas_kwargs.get('compression'))}"
         )

tests/test_s3_parquet.py

@@ -232,6 +232,7 @@ def test_to_parquet_filename_prefix(compare_filename_prefix, path, filename_pref
         use_threads=use_threads,
     )["paths"][0].split("/")[-1]
     compare_filename_prefix(filename, filename_prefix, test_prefix)
+    assert filename.endswith("bucket-00000.snappy.parquet")
 
 
 def test_read_parquet_map_types(path):

tests/test_s3_text.py

@@ -173,6 +173,7 @@ def test_to_text_filename_prefix(compare_filename_prefix, path, filename_prefix,
         use_threads=use_threads,
     )["paths"][0].split("/")[-1]
     compare_filename_prefix(filename, filename_prefix, test_prefix)
+    assert filename.endswith("bucket-00000.csv")
 
 
 def test_fwf(path):