fix: onFileClick logic is crashing the whole process if no workspace is open (#1119)

Author: volodkevych

app/aws-lsp-antlr4-runtimes/package.json

@@ -12,7 +12,7 @@
         "webpack": "webpack"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-antlr4": "*",
         "antlr4-c3": "^3.4.1",
         "antlr4ng": "^3.0.4"

app/aws-lsp-codewhisperer-runtimes/package.json

@@ -13,7 +13,7 @@
         "test": "node scripts/test-runner.js"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-codewhisperer": "*",
         "copyfiles": "^2.4.1",
         "cross-env": "^7.0.3",

app/aws-lsp-identity-runtimes/package.json

@@ -7,7 +7,7 @@
         "compile": "tsc --build"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-identity": "^0.0.1"
     }
 }

app/aws-lsp-json-runtimes/package.json

@@ -11,7 +11,7 @@
         "webpack": "webpack"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-json": "*"
     },
     "devDependencies": {

app/aws-lsp-notification-runtimes/package.json

@@ -7,7 +7,7 @@
         "compile": "tsc --build"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-notification": "^0.0.1"
     }
 }

app/aws-lsp-yaml-json-webworker/package.json

@@ -11,7 +11,7 @@
         "serve:webpack": "NODE_ENV=development webpack serve"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-json": "*",
         "@aws/lsp-yaml": "*"
     },

app/aws-lsp-yaml-runtimes/package.json

@@ -11,7 +11,7 @@
         "webpack": "webpack"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-yaml": "*"
     },
     "devDependencies": {

app/hello-world-lsp-runtimes/package.json

@@ -15,7 +15,7 @@
     },
     "dependencies": {
         "@aws/hello-world-lsp": "^0.0.1",
-        "@aws/language-server-runtimes": "^0.2.74"
+        "@aws/language-server-runtimes": "^0.2.76"
     },
     "devDependencies": {
         "@types/chai": "^4.3.5",

chat-client/package.json

@@ -22,8 +22,8 @@
     },
     "dependencies": {
         "@aws/chat-client-ui-types": "^0.1.28",
-        "@aws/language-server-runtimes-types": "^0.1.23",
-        "@aws/mynah-ui": "^4.31.0-beta.6"
+        "@aws/language-server-runtimes-types": "^0.1.25",
+        "@aws/mynah-ui": "^4.31.0-beta.7"
     },
     "devDependencies": {
         "@types/jsdom": "^21.1.6",

chat-client/src/client/mynahUi.ts

@@ -202,8 +202,8 @@ export const createMynahUi = (
             messager.onUiReady()
             messager.onTabAdd(initialTabId)
         },
-        onFileClick: (tabId, filePath, deleted, messageId, eventId) => {
-            messager.onFileClick({ tabId, filePath, messageId })
+        onFileClick: (tabId, filePath, deleted, messageId, eventId, fileDetails) => {
+            messager.onFileClick({ tabId, filePath, messageId, fullPath: fileDetails?.data?.['fullPath'] })
         },
         onTabAdd: (tabId: string) => {
             const defaultTabBarData = tabFactory.getDefaultTabData()
@@ -515,6 +515,9 @@ export const createMynahUi = (
                                     : '',
                             description: filePath,
                             clickable: true,
+                            data: {
+                                fullPath: fileDetails.fullPath || '',
+                            },
                         },
                     ])
                 ),

client/vscode/package.json

@@ -341,7 +341,7 @@
         "@aws-sdk/credential-providers": "^3.731.1",
         "@aws-sdk/types": "^3.734.0",
         "@aws/chat-client-ui-types": "^0.1.28",
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@types/uuid": "^9.0.8",
         "@types/vscode": "^1.98.0",
         "jose": "^5.2.4",

client/vscode/src/chatActivation.ts

@@ -44,7 +44,6 @@ import {
 } from 'vscode-languageclient/node'
 import * as jose from 'jose'
 import * as vscode from 'vscode'
-import * as fs from 'fs'
 
 export function registerChat(languageClient: LanguageClient, extensionUri: Uri, encryptionKey?: Buffer) {
     const webviewInitialized: Promise<Webview> = new Promise(resolveWebview => {
@@ -189,6 +188,7 @@ export function registerChat(languageClient: LanguageClient, extensionUri: Uri,
                         default:
                             if (isServerEvent(message.command))
                                 languageClient.sendNotification(message.command, message.params)
+                            else languageClient.info(`[VSCode Client]  Unhandled command: ${message.command}`)
                             break
                     }
                 }, undefined)

package-lock.json

@@ -28,7 +28,7 @@
         "clean": "rm -rf node_modules"
     },
     "dependencies": {
-        "@aws/language-server-runtimes": "^0.2.74",
+        "@aws/language-server-runtimes": "^0.2.76",
         "@aws/lsp-core": "^0.0.3"
     },
     "peerDependencies": {