fix: push banner message to initial tab after chat options are received

Author: viktorsaws

chat-client/src/client/chat.ts

@@ -41,6 +41,7 @@ import {
     CONTEXT_COMMAND_NOTIFICATION_METHOD,
     CONVERSATION_CLICK_REQUEST_METHOD,
     CREATE_PROMPT_NOTIFICATION_METHOD,
+    ChatMessage,
     ChatOptionsUpdateParams,
     ChatParams,
     ChatUpdateParams,
@@ -219,6 +220,23 @@ export const createChat = (
                 const allExistingTabs: MynahUITabStoreModel = mynahUi.getAllTabs()
                 const highlightCommand = featureConfig.get('highlightCommand')
 
+                if (tabFactory.initialTabId && allExistingTabs[tabFactory.initialTabId] && params?.chatNotifications) {
+                    // Edge case: push banner message to initial tab when ChatOptions are received
+                    // Because initial tab is added to MynahUi store at initialisation,
+                    // that tab does not have banner message, which arrives in ChatOptions above.
+                    const store = mynahUi.getTabData(tabFactory.initialTabId)?.getStore() || {}
+                    const chatItems = store.chatItems || []
+                    const updatedInitialItems = tabFactory.getChatItems(false, false, chatItems as ChatMessage[])
+
+                    // First clear the tab, so that messages are not appended https://github.com/aws/mynah-ui/blob/38608dff905b3790d85c73e2911ec7071c8a8cdf/docs/USAGE.md#using-updatestore-function
+                    mynahUi.updateStore(tabFactory.initialTabId, {
+                        chatItems: [],
+                    })
+                    mynahUi.updateStore(tabFactory.initialTabId, {
+                        chatItems: updatedInitialItems,
+                    })
+                }
+
                 for (const tabId in allExistingTabs) {
                     mynahUi.updateStore(tabId, {
                         ...tabFactory.getDefaultTabData(),

chat-client/src/client/mynahUi.ts

@@ -172,7 +172,6 @@ export const createMynahUi = (
     let disclaimerCardActive = !disclaimerAcknowledged
     let programmingModeCardActive = !pairProgrammingCardAcknowledged
     let contextCommandGroups: ContextCommandGroups | undefined
-    const initialTabId = TabFactory.generateUniqueId()
 
     let chatEventHandlers: ChatEventHandler = {
         onCodeInsertToCursorPosition(
@@ -234,7 +233,7 @@ export const createMynahUi = (
         },
         onReady: () => {
             messager.onUiReady()
-            messager.onTabAdd(initialTabId)
+            messager.onTabAdd(tabFactory.initialTabId)
         },
         onFileClick: (tabId, filePath, deleted, messageId, eventId, fileDetails) => {
             messager.onFileClick({ tabId, filePath, messageId, fullPath: fileDetails?.data?.['fullPath'] })
@@ -486,7 +485,7 @@ export const createMynahUi = (
 
     const mynahUiProps: MynahUIProps = {
         tabs: {
-            [initialTabId]: {
+            [tabFactory.initialTabId]: {
                 isSelected: true,
                 store: {
                     ...tabFactory.createTab(true),

chat-client/src/client/tabs/tabFactory.ts

@@ -19,6 +19,7 @@ export class TabFactory {
     private history: boolean = false
     private export: boolean = false
     private agenticMode: boolean = false
+    initialTabId: string
 
     public static generateUniqueId() {
         // from https://github.com/aws/mynah-ui/blob/a3799f47ca4b7c02850264e328539a40709a6858/src/helper/guid.ts#L6
@@ -31,7 +32,9 @@ export class TabFactory {
         private defaultTabData: DefaultTabData,
         private quickActionCommands?: QuickActionCommandGroup[],
         private bannerMessage?: ChatMessage
-    ) {}
+    ) {
+        this.initialTabId = TabFactory.generateUniqueId()
+    }
 
     public createTab(disclaimerCardActive: boolean): MynahUIDataModel {
         const tabData: MynahUIDataModel = {