feat(amazonq): add pair programming toggle #1013
Merged
+79
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 96e7ca3)
kmile
approved these changes
Apr 20, 2025
Hweinstock
approved these changes
Apr 20, 2025
There was a problem hiding this comment.
Did we confirm the heuristic used by the backend for checking if pair programming is on? I remember @kmile was able to trick it depending on which tools were included, which seems like a very fragile check.
|
The pair programming mode actually only (mostly?) influences which tools we run. The model doesn't know or care if the toggle is on or off, we don't send it to the backend. So in that sense, it correctly assumes it's in pair programming mode if it has pair programming tools, whether the setting is on or off. |
This was referenced Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing pair programming toggle
Solution
Add pair programming toggle on the bottom left of chat
Depends on aws/language-server-runtimes#449
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.