fix: avoid webpack path resolution interfering with vecLib import #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion interference
breedloj
approved these changes
Apr 21, 2025
| @@ -131,7 +131,7 @@ export class LocalProjectContextController { | |||
| ) | |||
|
|
|||
| const libraryPath = path.join(LIBRARY_DIR, 'dist', 'extension.js') | |||
| const vecLib = vectorLib ?? (await import(libraryPath)) | |||
| const vecLib = vectorLib ?? (await eval(`import("${libraryPath}")`)) | |||
There was a problem hiding this comment.
doesn't eval carry a bit of risk? But I can merge to unblock the bug bash
jpinkney-aws
approved these changes
Apr 21, 2025
This was referenced Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Webpack is trying to handle the dynamic import for the vector libary using its own module resolution system. This causes the library to fail at runtime.
Solution
Import the library using eval, which webpack will ignore and leave the path resolution unchanged.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.