feat: route button event through chat-client. #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -311,6 +312,13 @@ export const createMynahUi = ( | |||
| Object.keys(mynahUi.getAllTabs()).forEach(storeTabKey => { | |||
| mynahUi.updateStore(storeTabKey, { promptInputStickyCard: null }) | |||
| }) | |||
| } else { | |||
| const payload: ButtonClickParams = { | |||
There was a problem hiding this comment.
oh wait so tool clicks are going to come through onInBodyButtonClicked?
There was a problem hiding this comment.
Yeah, this is how its implemented on agentic-chat branch here. Which took forever to find since its redirected almost 10 times.
jpinkney-aws
approved these changes
Apr 22, 2025
Hweinstock
added a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Apr 22, 2025
## Problem With aws/language-servers#1037, the chat client will forward the button click event to the host client (VSC in this case). We are then responsible for making a request to the LSP with this button click. ## Solution - route the button click to the LSP. - log any failed button click actions. ## Verification See aws/language-servers#1037, for a demo of the e2e button hookup working. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
the buttonClick event was not routed yet, but was implemented in runtimes here: aws/language-server-runtimes#464
Solution
Verification
Demo:
verification.mov
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.