fix: improve chat rendering if there are additional chat messages #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmile
force-pushed
the
improve-additional-chat-messages
branch
2 times, most recently
from
4f2b8e3 to
e7aed5b
Compare
kmile
force-pushed
the
improve-additional-chat-messages
branch
2 times, most recently
from
fd248a4 to
21c17a1
Compare
jpinkney-aws
approved these changes
Apr 22, 2025
|
|
||
| mynahUi.updateLastChatAnswer(tabId, { | ||
| type: ChatItemType.ANSWER, | ||
| mynahUi.endMessageStream(tabId, chatResult.messageId ?? '', { |
There was a problem hiding this comment.
does this have the potential to break history if we aren't finishing with an answer card?
There was a problem hiding this comment.
This doesn't have to be the last card, just the one specified.
And in the backend, we only put the current assistantResponse items in the chatResult, the tools and previous responses go in the additionalMessages.
There was a problem hiding this comment.
History is done on the server and yes, it currently breaks if we have lingering toolUses until we port over https://github.com/aws/aws-toolkit-vscode/blob/feature/agentic-chat/packages/core/src/shared/db/chatDb/chatDb.ts#L311
kmile
force-pushed
the
improve-additional-chat-messages
branch
2 times, most recently
from
cea8bf1 to
6fad504
Compare
kmile
force-pushed
the
improve-additional-chat-messages
branch
2 times, most recently
from
a8955ee to
3420883
Compare
viktorsaws
approved these changes
Apr 22, 2025
kmile
force-pushed
the
improve-additional-chat-messages
branch
from
3420883 to
fe12ed9
Compare
kmile
force-pushed
the
improve-additional-chat-messages
branch
from
fe12ed9 to
59098f0
Compare
viktorsaws
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Remove a lot of unnecessary progress updates.
Reduces flickering in tool cards.
Enables streaming animation when rendering assistant responses.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.